Bug 108388

Summary: [BlackBerry] store proxy and host auth credentials separately
Product: WebKit Reporter: Joe Mason <joenotcharles>
Component: Page LoadingAssignee: Joe Mason <joenotcharles>
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
yong.li.webkit: review+, yong.li.webkit: commit-queue-
fixed style none

Description Joe Mason 2013-01-30 14:53:45 PST
The platform layer NetworkRequest object has been updated to take both host and proxy credentials in the same request. To support this the webkit layer must be updated to pass both sets of credentials at the same time.
Comment 1 Joe Mason 2013-01-30 14:55:44 PST
Created attachment 185586 [details]
Comment 2 WebKit Review Bot 2013-01-30 15:01:31 PST
Attachment 185586 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/ResourceHandleInternal.h', u'Source/WebCore/platform/network/blackberry/AuthenticationChallenge.h', u'Source/WebCore/platform/network/blackberry/NetworkJob.cpp', u'Source/WebCore/platform/network/blackberry/NetworkJob.h', u'Source/WebCore/platform/network/blackberry/NetworkManager.cpp']" exit_code: 1
Source/WebCore/platform/network/blackberry/NetworkJob.h:77:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/platform/network/blackberry/NetworkJob.cpp:353:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/network/blackberry/NetworkJob.cpp:354:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/network/blackberry/NetworkJob.cpp:355:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/network/blackberry/NetworkJob.cpp:356:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 5 in 6 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yong Li 2013-01-30 15:01:56 PST
Comment on attachment 185586 [details]

r+ based on Leo's review
Comment 4 Yong Li 2013-01-30 15:02:28 PST
Comment on attachment 185586 [details]

oops. style error?
Comment 5 Joe Mason 2013-01-30 15:04:46 PST
Weird, check-webkit-style locally didn't catch it.

I'll fix and resubmit.
Comment 6 Joe Mason 2013-01-30 15:08:48 PST
Created attachment 185592 [details]
fixed style
Comment 7 WebKit Review Bot 2013-01-30 17:27:54 PST
Comment on attachment 185592 [details]
fixed style

Clearing flags on attachment: 185592

Committed r141350: <http://trac.webkit.org/changeset/141350>
Comment 8 WebKit Review Bot 2013-01-30 17:27:58 PST
All reviewed patches have been landed.  Closing bug.