Bug 108361

Summary: IndexedDB: clean up scheduleTask return type
Product: WebKit Reporter: Alec Flett <alecflett>
Component: New BugsAssignee: Alec Flett <alecflett>
Status: RESOLVED FIXED    
Severity: Normal CC: jsbell, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alec Flett
Reported 2013-01-30 11:39:51 PST
IndexedDB: clean up scheduleTask return type
Attachments
Patch (5.54 KB, patch)
2013-01-30 11:43 PST, Alec Flett 		no flags
DetailsFormatted DiffDiff
Patch (6.10 KB, patch)
2013-01-30 14:25 PST, Alec Flett 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alec Flett
Comment 1 2013-01-30 11:43:42 PST
Created attachment 185528 [details] Patch
Alec Flett
Comment 2 2013-01-30 11:50:09 PST
jsbell@ - and here's the other cleanup
Joshua Bell
Comment 3 2013-01-30 11:57:06 PST
Comment on attachment 185528 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185528&action=review > Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:919 > if (!transaction || transaction->isFinished()) The isFinished() test can be removed now. > Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp:75 > + ASSERT(m_state != Finished); Should return early, not ASSERT.
Alec Flett
Comment 4 2013-01-30 14:25:16 PST
Created attachment 185572 [details] Patch
Alec Flett
Comment 5 2013-01-30 14:29:18 PST
tony@ - r?
WebKit Review Bot
Comment 6 2013-01-30 15:32:11 PST
Comment on attachment 185572 [details] Patch Clearing flags on attachment: 185572 Committed r141332: <http://trac.webkit.org/changeset/141332>
WebKit Review Bot
Comment 7 2013-01-30 15:32:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.