Bug 108343

Summary: [chromium] move postMessage related methods to TestRunner library
Product: WebKit Reporter: jochen
Component: New BugsAssignee: jochen
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

jochen
Reported 2013-01-30 07:15:01 PST
[chromium] move postMessage related methods to TestRunner library
Attachments
Patch (4.91 KB, patch)
2013-01-30 07:15 PST, jochen 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.61 KB, patch)
2013-01-30 14:07 PST, jochen 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.09 KB, patch)
2013-01-30 23:44 PST, jochen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2013-01-30 07:15:24 PST
Created attachment 185501 [details] Patch
WebKit Review Bot
Comment 2 2013-01-30 07:21:01 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
jochen
Comment 3 2013-01-30 14:07:13 PST
Created attachment 185558 [details] Patch for landing
WebKit Review Bot
Comment 4 2013-01-30 14:57:13 PST
Comment on attachment 185558 [details] Patch for landing Rejecting attachment 185558 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: :willCheckAndDispatchMessageEvent(WebKit::WebFrame*, WebKit::WebFrame*, WebKit::WebSecurityOrigin, WebKit::WebDOMMessageEvent)' without object ../../Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:461: error: 'Base' has not been declared ../../Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: At global scope: ../../Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:465: error: expected declaration before '}' token ninja: build stopped: subcommand failed. Full output: http://queues.webkit.org/results/16195924
jochen
Comment 5 2013-01-30 23:44:31 PST
Created attachment 185691 [details] Patch for landing
WebKit Review Bot
Comment 6 2013-01-31 00:32:24 PST
Comment on attachment 185691 [details] Patch for landing Clearing flags on attachment: 185691 Committed r141385: <http://trac.webkit.org/changeset/141385>
WebKit Review Bot
Comment 7 2013-01-31 00:32:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.