Bug 108313

Summary: Web Inspector: migrate file selection dialog to the viewport.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch vsevik: review+

Description Pavel Feldman 2013-01-30 02:13:53 PST 
Otherwise it takes too long to render.
Comment 1 Pavel Feldman 2013-01-30 02:15:40 PST 
Created attachment 185438 [details]
Patch
Comment 2 Pavel Feldman 2013-01-30 02:29:59 PST 
Created attachment 185441 [details]
Patch
Comment 3 Vsevolod Vlasov 2013-01-30 04:10:47 PST 
Comment on attachment 185441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=185441&action=review

> Source/WebCore/ChangeLog:66
> +        (WebInspector.ViewportControl.Provider.protowarning: LF will be replaced by CRLF in Source/WebCore/WebCore.vcproj/WebCore.vcproj.

Is that fine?

> Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:544
> +        setTimeout(function() { this._uiSourceCodes.sort(compareFunction); }.bind(this), 0);

setTimeout(this._uiSourceCodes.sort.bind(this._uiSourceCodes, compareFunction), 0);
Comment 4 Pavel Feldman 2013-01-30 04:49:14 PST 
Committed r141258: <http://trac.webkit.org/changeset/141258>