Summary: | Rename from parentOrHost* to parentOrShadowHost*. | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Changhun Kang <chkang514> | ||||||||||||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | abarth, adamk, allan.jensen, cmarcelo, dglazkov, dominicc, d-r, eric.carlson, eric, feature-media-reviews, fmalita, haraken, japhet, kling, macpherson, menard, mifenton, morrita, ojan.autocc, pdr, schenney, skyul, webkit.review.bot | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | All | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Changhun Kang
2013-01-30 01:05:09 PST
Created attachment 185428 [details]
Patch
Comment on attachment 185428 [details] Patch Rejecting attachment 185428 [details] from review queue. temoochin@company100.net does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. Comment on attachment 185428 [details] Patch Rejecting attachment 185428 [details] from commit-queue. temoochin@company100.net does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Created attachment 185437 [details]
Patch
Sorry,
I miss-clicked commit + and review + buttons.
This patch is exactly same previous one.
Comment on attachment 185428 [details]
Patch
Obsoleting this apparently duplicate patch.
Comment on attachment 185437 [details]
Patch
I am not a reviewer, but this change looks good to me. A straightforward renaming. For context, I think the reason for the FIXME in the first instance is that the term "host" is now overloaded: ShadowRoots are attached to shadow hosts (nee host) and template elements host their content. If the EWS likes this I think it should be accepted.
Comment on attachment 185437 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185437&action=review > Source/WebCore/ChangeLog:10 > + * bindings/js/JSDOMBinding.h: In this type of patch (a straightforward rename), just zap this whole generated laundry list. It's not very useful. Created attachment 185603 [details]
Patch
I zapped change file list in ChangeLog.
Comment on attachment 185603 [details] Patch Rejecting attachment 185603 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 185603, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: re/svg/SVGForeignObjectElement.cpp patching file Source/WebCore/svg/SVGGElement.cpp patching file Source/WebCore/svg/SVGLocatable.cpp patching file Source/WebCore/svg/SVGStyledElement.cpp patching file Source/WebKit2/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit2/WebProcess/WebPage/WebPage.cpp Hunk #1 succeeded at 1774 (offset 2 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16200948 Created attachment 185613 [details]
Patch
I fixed the conflict.
Created attachment 185622 [details]
Patch
I fixed some conflicts.
Comment on attachment 185622 [details] Patch Rejecting attachment 185622 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'validate-changelog', '--non-interactive', 185622, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/16199970 Created attachment 185899 [details]
Patch
I add a review comment.
Comment on attachment 185899 [details] Patch Clearing flags on attachment: 185899 Committed r141524: <http://trac.webkit.org/changeset/141524> Looks like this was fixed. Closing. Comment on attachment 185622 [details]
Patch
The work on the bug has ceased, removing the r? flag on this patch.
|