Bug 108269

Summary:

Remove MessageID parameter from Connection::sendMessage

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+

Anders Carlsson

Reported 2013-01-29 17:30:29 PST

Remove MessageID parameter from Connection::sendMessage

Attachments
Patch (13.26 KB, patch) 2013-01-29 17:33 PST, Anders Carlsson	sam: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2013-01-29 17:33:11 PST

Created attachment 185357 [details] Patch

WebKit Review Bot

Comment 2 2013-01-29 17:36:23 PST

Attachment 185357 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/Connection.cpp', u'Source/WebKit2/Platform/CoreIPC/Connection.h', u'Source/WebKit2/Platform/CoreIPC/MessageSender.h', u'Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp', u'Source/WebKit2/Shared/ChildProcessProxy.cpp', u'Source/WebKit2/Shared/WebConnection.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp']" exit_code: 1 Source/WebKit2/Platform/CoreIPC/Connection.h:184: Local variables should never be PassOwnPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Source/WebKit2/Platform/CoreIPC/Connection.h:185: Local variables should never be PassOwnPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Total errors found: 2 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 3 2013-01-29 17:40:39 PST

Committed r141191: <http://trac.webkit.org/changeset/141191>

Note You need to log in before you can comment on or make changes to this bug.