Bug 108178

Summary: Compilation warning in JSC
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: JavaScriptCoreAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Severity: Normal CC: fpizlo, ggaren, haraken, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
patch none

Description Mikhail Pozdnyakov 2013-01-29 03:48:32 PST
WebKit builds on EFL bots fail due to following compilation warning:

/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/JavaScriptCore/runtime/Structure.cpp: In constructor ‘JSC::Structure::Structure(JSC::JSGlobalData&, JSC::JSGlobalObject*, JSC::JSValue, const JSC::TypeInfo&, const JSC::ClassInfo*, JSC::IndexingType, unsigned int)’:
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/JavaScriptCore/runtime/Structure.cpp:175:25: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1plus: all warnings being treated as errors

Comment 1 Mikhail Pozdnyakov 2013-01-29 03:59:13 PST
Created attachment 185215 [details]
Comment 2 Kentaro Hara 2013-01-29 04:20:36 PST
Comment on attachment 185215 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=185215&action=review

looks ok.

> Source/JavaScriptCore/ChangeLog:3
> +        Compilation warning in JSC

From next time, you might want to mention what revision caused the regression. (r141050 in this case.)
Comment 3 WebKit Review Bot 2013-01-29 04:55:31 PST
Comment on attachment 185215 [details]

Clearing flags on attachment: 185215

Committed r141099: <http://trac.webkit.org/changeset/141099>
Comment 4 WebKit Review Bot 2013-01-29 04:55:34 PST
All reviewed patches have been landed.  Closing bug.