Bug 108160

Summary: WebFrameTest.DisambiguationPopup is failing
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: Tools / TestsAssignee: dfalcantara
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dfalcantara, trchen, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Keishi Hattori
Reported 2013-01-29 00:24:10 PST
WebFrameTest.DisambiguationPopup is failing
Attachments
Patch (2.73 KB, patch)
2013-01-30 13:57 PST, dfalcantara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
dfalcantara
Comment 1 2013-01-30 13:49:56 PST
Error says: [3603:3612:0128/154721:1245294047:FATAL:url_request_context.cc(121)] Check failed: false. Leaked 1 URLRequest(s). First URL: http://www.test.com/disambiguation_popup.html. [3603:3612:0128/154721:1245294047:FATAL:url_request_context.cc(121)] Check failed: false. Leaked 1 URLRequest(s). First URL: http://www.test.com/disambiguation_popup.html. One of the unit tests appears to be using the wrong html file.
dfalcantara
Comment 2 2013-01-30 13:57:30 PST
Created attachment 185557 [details] Patch
Tien-Ren Chen
Comment 3 2013-01-30 16:27:36 PST
LGTM
Adam Barth
Comment 4 2013-01-31 11:10:38 PST
Comment on attachment 185557 [details] Patch Great!
WebKit Review Bot
Comment 5 2013-01-31 11:41:47 PST
Comment on attachment 185557 [details] Patch Clearing flags on attachment: 185557 Committed r141454: <http://trac.webkit.org/changeset/141454>
WebKit Review Bot
Comment 6 2013-01-31 11:41:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.