Bug 108086

Summary: [chromium] Missing include in AssertMatchingEnums.cpp
Product: WebKit Reporter: Mike West <mkwst>
Component: WebCore Misc.Assignee: Mike West <mkwst>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Mike West 2013-01-28 08:32:08 PST
With SVG disabled, the Chromium build is currently broken due to a missing include in Source/WebKit/chromium/src/AssertMatchingEnums.cpp:

../../Source/WebKit/chromium/src/AssertMatchingEnums.cpp:634:63: error: no member named 'ResourceLoadPriorityVeryHigh' in namespace 'WebCore'
COMPILE_ASSERT_MATCHING_ENUM(WebURLRequest::PriorityVeryHigh, ResourceLoadPriorityVeryHigh);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../Source/WebKit/chromium/src/AssertMatchingEnums.cpp:131:61: note: expanded from macro 'COMPILE_ASSERT_MATCHING_ENUM'
    COMPILE_ASSERT(int(WebKit::webkit_name) == int(WebCore::webcore_name), mismatching_enums)
                                                            ^
../../Source/WebKit/chromium/base/basictypes.h:206:31: note: expanded from macro 'COMPILE_ASSERT'
  typedef CompileAssert<(bool(expr))> msg[bool(expr) ? 1 : -1]
                              ^~~~
../../Source/WebKit/chromium/src/AssertMatchingEnums.cpp:634:63: error: no member named 'ResourceLoadPriorityVeryHigh' in namespace 'WebCore'
COMPILE_ASSERT_MATCHING_ENUM(WebURLRequest::PriorityVeryHigh, ResourceLoadPriorityVeryHigh);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../Source/WebKit/chromium/src/AssertMatchingEnums.cpp:131:61: note: expanded from macro 'COMPILE_ASSERT_MATCHING_ENUM'
    COMPILE_ASSERT(int(WebKit::webkit_name) == int(WebCore::webcore_name), mismatching_enums)

And so on...
Comment 1 Mike West 2013-01-28 08:34:38 PST
Created attachment 184989 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-28 08:56:31 PST
Comment on attachment 184989 [details]
Patch

Clearing flags on attachment: 184989

Committed r140971: <http://trac.webkit.org/changeset/140971>
Comment 3 WebKit Review Bot 2013-01-28 08:56:35 PST
All reviewed patches have been landed.  Closing bug.