Bug 10807

Summary:

REGRESSION (r16259): Repro crash on manual-tests/svg-repaint-image.svg

Product:

WebKit

Reporter:

mitz

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

rwlbuis

Priority:

Keywords:

Regression

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
First attempt	mjs: review+

mitz

Reported 2006-09-10 15:43:36 PDT

Safari crashes when you click the B in manual-tests/svg-repaint-image.svg. This is a regression from r16259 (fix for bug 9753). "CGContextRestoreGState: invalid context" Backtrace: Thread 0 Crashed: 0 com.apple.CoreGraphics 0x903cc44c CGGStackRestore + 136 1 com.apple.WebCore 0x01068c90 WebCore::RenderSVGContainer::paint(WebCore::RenderObject::PaintInfo&, int, int) + 2400 2 com.apple.WebCore 0x011840a4 WebCore::RenderBox::paint(WebCore::RenderObject::PaintInfo&, int, int) + 116 3 com.apple.WebCore 0x01068bcc WebCore::RenderSVGContainer::paint(WebCore::RenderObject::PaintInfo&, int, int) + 2204 4 com.apple.WebCore 0x0118e9c0 WebCore::RenderView::paint(WebCore::RenderObject::PaintInfo&, int, int) + 256 5 com.apple.WebCore 0x011a61d0 WebCore::RenderLayer::paintLayer(WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::IntRect const&, bool, WebCore::PaintRestriction, WebCore::RenderObject*) + 1104 6 com.apple.WebCore 0x010de114 WebCore::Frame::paint(WebCore::GraphicsContext*, WebCore::IntRect const&) + 196 7 com.apple.WebCore 0x0111b9d8 -[WebCoreFrameBridge drawRect:] + 168 8 com.apple.WebKit 0x003389a0 -[WebHTMLView drawSingleRect:] + 288 9 com.apple.WebKit 0x00338c2c -[WebHTMLView drawRect:] + 348 10 com.apple.AppKit 0x93734858 -[NSView _drawRect:clip:] + 2128 11 com.apple.AppKit 0x937335fc -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 736 12 com.apple.WebKit 0x00333b48 -[WebHTMLView(WebPrivate) _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 296 13 com.apple.AppKit 0x937339a8 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 1676 14 com.apple.AppKit 0x937339a8 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 1676 15 com.apple.AppKit 0x937339a8 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 1676 16 com.apple.AppKit 0x937339a8 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 1676 17 com.apple.AppKit 0x937339a8 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 1676 18 com.apple.AppKit 0x937339a8 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 1676 19 com.apple.AppKit 0x937339a8 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 1676 20 com.apple.AppKit 0x93754044 -[NSThemeFrame _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 192 21 com.apple.AppKit 0x9372d054 -[NSView _displayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] + 384 22 com.apple.AppKit 0x93722348 -[NSView displayIfNeeded] + 248 23 com.apple.AppKit 0x937221b8 -[NSWindow displayIfNeeded] + 180 24 com.apple.Safari 0x0001a5f8 0x1000 + 103928 25 com.apple.AppKit 0x93722064 _handleWindowNeedsDisplay + 200 26 com.apple.CoreFoundation 0x907db73c __CFRunLoopDoObservers + 352 27 com.apple.CoreFoundation 0x907db9dc __CFRunLoopRun + 420 28 com.apple.CoreFoundation 0x907db47c CFRunLoopRunSpecific + 268 29 com.apple.HIToolbox 0x931eb740 RunCurrentEventLoopInMode + 264 30 com.apple.HIToolbox 0x931eadd4 ReceiveNextEventCommon + 380 31 com.apple.HIToolbox 0x931eac40 BlockUntilNextEventMatchingListInMode + 96 32 com.apple.AppKit 0x936eeae4 _DPSNextEvent + 384 33 com.apple.AppKit 0x936ee7a8 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 116 34 com.apple.Safari 0x00006740 0x1000 + 22336 35 com.apple.AppKit 0x936eacec -[NSApplication run] + 472 36 com.apple.AppKit 0x937db87c NSApplicationMain + 452 37 com.apple.Safari 0x0005c77c 0x1000 + 374652 38 com.apple.Safari 0x0005c624 0x1000 + 374308

Attachments
First attempt (2.51 KB, patch) 2006-09-11 13:45 PDT, Rob Buis	mjs: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Rob Buis

Comment 1 2006-09-11 13:45:50 PDT

Created attachment 10505 [details] First attempt This patch should fix both regressions (10806 and 10807). Cheers, Rob.

Maciej Stachowiak

Comment 2 2006-09-12 00:23:27 PDT

Comment on attachment 10505 [details] First attempt r=me

Eric Seidel (no email)

Comment 3 2006-09-12 22:33:40 PDT

Patch fails to apply cleanly. I'll leave rob to deal with this one.

Rob Buis

Comment 4 2006-09-21 02:24:54 PDT

(In reply to comment #3) > Patch fails to apply cleanly. I'll leave rob to deal with this one. > Landed in r16421.

Note You need to log in before you can comment on or make changes to this bug.