Bug 108061

Summary:

[CMake] Use offical Windows CE support

Product:

WebKit

Reporter:

Patrick R. Gansterer <paroga>

Component:

Tools / Tests

Assignee:

Patrick R. Gansterer <paroga>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dbates, laszlo.gombos, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

97592

Attachments:

Description	Flags
Patch	laszlo.gombos: review+, paroga: commit-queue-

Description Patrick R. Gansterer 2013-01-28 00:58:39 PST

[CMake] Use offical Windwos CE support

Comment 1 Patrick R. Gansterer 2013-01-28 02:07:45 PST

Created attachment 184959 [details]
Patch

Comment 2 Daniel Bates 2013-01-28 22:57:48 PST

Comment on attachment 184959 [details]
Patch

Can you elaborate on when such support was added to CMake?

Comment 3 Patrick R. Gansterer 2013-01-28 23:40:43 PST

(In reply to comment #2)
> (From update of attachment 184959 [details])
> Can you elaborate on when such support was added to CMake?

It's in the current master already, but not in a released version. Main merge can be seen at http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=581b0c0d078b5f07f68a53b118f44fc6e8313601

Comment 4 Laszlo Gombos 2013-01-29 05:53:24 PST

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 184959 [details] [details])
> > Can you elaborate on when such support was added to CMake?
> 
> It's in the current master already, but not in a released version. Main merge can be seen at http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=581b0c0d078b5f07f68a53b118f44fc6e8313601

According to http://www.vtk.org/Wiki/CMake_Cross_Compiling this is in CMake 2.8.11.

Would it make sense to add cmake_minimum_required(VERSION 2.8.3) to OptionsWinCE.cmake (or somewhere else and guard it with WinCE).

The change in webkitdirs.pm looks good to me.

Comment 5 Laszlo Gombos 2013-01-29 05:54:26 PST

Comment on attachment 184959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184959&action=review

> Tools/ChangeLog:3
> +        [CMake] Use offical Windwos CE support

Typo: Windwos --> Windows.

Comment 6 Patrick R. Gansterer 2013-01-29 05:57:47 PST

(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (From update of attachment 184959 [details] [details] [details])
> > > Can you elaborate on when such support was added to CMake?
> > 
> > It's in the current master already, but not in a released version. Main merge can be seen at http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=581b0c0d078b5f07f68a53b118f44fc6e8313601
> 
> According to http://www.vtk.org/Wiki/CMake_Cross_Compiling this is in CMake 2.8.11.
> 
> Would it make sense to add cmake_minimum_required(VERSION 2.8.3) to OptionsWinCE.cmake (or somewhere else and guard it with WinCE).

No, since the WinCE port is not Windows CE only and can be built on Win32 with older compilers too.


(In reply to comment #5)
> (From update of attachment 184959 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=184959&action=review
> 
> > Tools/ChangeLog:3
> > +        [CMake] Use offical Windwos CE support
> 
> Typo: Windwos --> Windows.

I'll fix it when landing manually.

Can someone please r+ this simple change?

Comment 7 Laszlo Gombos 2013-01-29 08:31:55 PST

Comment on attachment 184959 [details]
Patch

r=me. Please fix the typo in the ChangeLog title before landing.

Comment 8 Patrick R. Gansterer 2013-01-29 12:09:57 PST

Committed r141137: <http://trac.webkit.org/changeset/141137>