Bug 108061

Summary: [CMake] Use offical Windows CE support
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Tools / TestsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, laszlo.gombos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 97592    
Attachments:
Description Flags
Patch laszlo.gombos: review+, paroga: commit-queue-

Patrick R. Gansterer
Reported 2013-01-28 00:58:39 PST
[CMake] Use offical Windwos CE support
Attachments
Patch (1.24 KB, patch)
2013-01-28 02:07 PST, Patrick R. Gansterer 		laszlo.gombos: review+
paroga: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2013-01-28 02:07:45 PST
Created attachment 184959 [details] Patch
Daniel Bates
Comment 2 2013-01-28 22:57:48 PST
Comment on attachment 184959 [details] Patch Can you elaborate on when such support was added to CMake?
Patrick R. Gansterer
Comment 3 2013-01-28 23:40:43 PST
(In reply to comment #2) > (From update of attachment 184959 [details]) > Can you elaborate on when such support was added to CMake? It's in the current master already, but not in a released version. Main merge can be seen at http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=581b0c0d078b5f07f68a53b118f44fc6e8313601
Laszlo Gombos
Comment 4 2013-01-29 05:53:24 PST
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 184959 [details] [details]) > > Can you elaborate on when such support was added to CMake? > > It's in the current master already, but not in a released version. Main merge can be seen at http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=581b0c0d078b5f07f68a53b118f44fc6e8313601 According to http://www.vtk.org/Wiki/CMake_Cross_Compiling this is in CMake 2.8.11. Would it make sense to add cmake_minimum_required(VERSION 2.8.3) to OptionsWinCE.cmake (or somewhere else and guard it with WinCE). The change in webkitdirs.pm looks good to me.
Laszlo Gombos
Comment 5 2013-01-29 05:54:26 PST
Comment on attachment 184959 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184959&action=review > Tools/ChangeLog:3 > + [CMake] Use offical Windwos CE support Typo: Windwos --> Windows.
Patrick R. Gansterer
Comment 6 2013-01-29 05:57:47 PST
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 184959 [details] [details] [details]) > > > Can you elaborate on when such support was added to CMake? > > > > It's in the current master already, but not in a released version. Main merge can be seen at http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=581b0c0d078b5f07f68a53b118f44fc6e8313601 > > According to http://www.vtk.org/Wiki/CMake_Cross_Compiling this is in CMake 2.8.11. > > Would it make sense to add cmake_minimum_required(VERSION 2.8.3) to OptionsWinCE.cmake (or somewhere else and guard it with WinCE). No, since the WinCE port is not Windows CE only and can be built on Win32 with older compilers too. (In reply to comment #5) > (From update of attachment 184959 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=184959&action=review > > > Tools/ChangeLog:3 > > + [CMake] Use offical Windwos CE support > > Typo: Windwos --> Windows. I'll fix it when landing manually. Can someone please r+ this simple change?
Laszlo Gombos
Comment 7 2013-01-29 08:31:55 PST
Comment on attachment 184959 [details] Patch r=me. Please fix the typo in the ChangeLog title before landing.
Patrick R. Gansterer
Comment 8 2013-01-29 12:09:57 PST
Committed r141137: <http://trac.webkit.org/changeset/141137>
Note You need to log in before you can comment on or make changes to this bug.