Summary: | Disable -webkit-overflow-scrolling CSS attribute on Chromium | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sami Kyöstilä <skyostil> | ||||||||||||||
Component: | New Bugs | Assignee: | Sami Kyöstilä <skyostil> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | allan.jensen, buildbot, cmarcelo, ddkilzer, dglazkov, eric, gyuyoung.kim, jamesr, macpherson, menard, ojan.autocc, rakuco, rniwa, simon.fraser, webkit.review.bot | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Sami Kyöstilä
2013-01-26 19:02:12 PST
Created attachment 184895 [details]
Patch
First pass to check test expectations.
Comment on attachment 184895 [details] Patch Attachment 184895 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16163009 New failing tests: compositing/overflow/scrolling-content-clip-to-viewport.html compositing/overflow/scrolling-without-painting.html compositing/overflow/updating-scrolling-content.html Comment on attachment 184895 [details] Patch Attachment 184895 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16160031 New failing tests: platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-content-clip-to-viewport.html platform/chromium/virtual/softwarecompositing/overflow/scrolling-content-clip-to-viewport.html platform/chromium/virtual/softwarecompositing/overflow/scrolling-without-painting.html compositing/overflow/scrolling-content-clip-to-viewport.html platform/chromium/virtual/softwarecompositing/overflow/updating-scrolling-content.html compositing/overflow/scrolling-without-painting.html compositing/overflow/updating-scrolling-content.html Comment on attachment 184895 [details] Patch Attachment 184895 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16150575 New failing tests: compositing/overflow/scrolling-content-clip-to-viewport.html compositing/overflow/scrolling-without-painting.html compositing/overflow/updating-scrolling-content.html I'm tempted to suggest that you leave it in but #ifdef it PLATFORM(IOS), since I'm not sure that we'll want to do automatic composited scrolling on iOS yet. Created attachment 185515 [details]
Patch
- Removed tests specific to -webkit-overflow-scroll.
- Converted other composited scrolling tests to use
setAcceleratedCompositingForOverflowScrollEnabled() instead. These should
pass on all platforms that support accelerated compositing.
- Enabled composited overflow scrolling in ScrollingCoordinatorChromiumTest.
Ah, I missed your comment Simon. I'll do another round to leave the flag in but disable it just for Chromium. I think the tests can also be made to work in both modes. Created attachment 185536 [details]
Patch
- Only disable this on Chromium.
Comment on attachment 185536 [details] Patch Attachment 185536 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16218706 New failing tests: platform/chromium/virtual/softwarecompositing/overflow/overflow-auto-with-touch.html platform/chromium/virtual/softwarecompositing/overflow/overflow-auto-with-touch-toggle.html platform/chromium/virtual/softwarecompositing/overflow/nested-scrolling.html compositing/overflow/nested-scrolling.html platform/chromium/virtual/softwarecompositing/overflow/overflow-overlay-with-touch.html Created attachment 185738 [details]
Patch
- Updated test expectations and baselines.
Comment on attachment 185738 [details] Patch Attachment 185738 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16282267 New failing tests: platform/chromium/virtual/softwarecompositing/overflow/overflow-auto-with-touch-toggle.html Created attachment 185796 [details]
Patch
- One more test that I missed.
I think this is now good to go. Anyone wanna have a look? Comment on attachment 185796 [details] Patch Rejecting attachment 185796 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 185796, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 167605 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 54>At revision 167605. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/16333105 Created attachment 186327 [details]
Patch
- Rebased.
Comment on attachment 186327 [details] Patch Clearing flags on attachment: 186327 Committed r141769: <http://trac.webkit.org/changeset/141769> All reviewed patches have been landed. Closing bug. |