Bug 107914

Summary: Wrap content filtering code in an object
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, japhet, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ap: review+, buildbot: commit-queue-

Andy Estes
Reported 2013-01-24 22:05:10 PST
Wrap content filtering code in an object
Attachments
Patch (25.97 KB, patch)
2013-01-24 22:42 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (25.68 KB, patch)
2013-01-25 15:24 PST, Andy Estes 		ap: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2013-01-24 22:42:27 PST
Created attachment 184671 [details] Patch
Andy Estes
Comment 2 2013-01-25 15:24:30 PST
Created attachment 184815 [details] Patch
Build Bot
Comment 3 2013-01-25 15:50:11 PST
Comment on attachment 184815 [details] Patch Attachment 184815 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16113629
Alexey Proskuryakov
Comment 4 2013-01-25 16:01:28 PST
Comment on attachment 184815 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184815&action=review > Source/WebCore/loader/MainResourceLoader.h:40 > +#include "ContentFilter.h" Please don't include it, a forward declaration should suffice (and if it doesn't, please fix whatever is preventing it from working).
Andy Estes
Comment 5 2013-01-25 16:12:21 PST
Committed r140875: <http://trac.webkit.org/changeset/140875>
Ryosuke Niwa
Comment 6 2013-01-28 11:54:27 PST
It appears that this broke a unit test WebKit2.DownloadDecideDestinationCrash: http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK1%20%28Tests%29/builds/4964/steps/run-api-tests/logs/stdio Blame list: http://trac.webkit.org/log/?verbose=on&rev=140882&stop_rev=140875
Andy Estes
Comment 7 2013-01-30 14:18:10 PST
(In reply to comment #6) > It appears that this broke a unit test WebKit2.DownloadDecideDestinationCrash: > http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK1%20%28Tests%29/builds/4964/steps/run-api-tests/logs/stdio > > Blame list: http://trac.webkit.org/log/?verbose=on&rev=140882&stop_rev=140875 This was due to some unrelated WKSI changes that got pulled in by <http://trac.webkit.org/changeset/140876/>. Alexey fixed this in <http://trac.webkit.org/changeset/141285> and the API test is no longer failing on the bot.
Ryosuke Niwa
Comment 8 2013-01-30 14:32:06 PST
(In reply to comment #7) > (In reply to comment #6) > > It appears that this broke a unit test WebKit2.DownloadDecideDestinationCrash: > > http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK1%20%28Tests%29/builds/4964/steps/run-api-tests/logs/stdio > > > > Blame list: http://trac.webkit.org/log/?verbose=on&rev=140882&stop_rev=140875 > > This was due to some unrelated WKSI changes that got pulled in by <http://trac.webkit.org/changeset/140876/>. Alexey fixed this in <http://trac.webkit.org/changeset/141285> and the API test is no longer failing on the bot. Thanks a lot for the follow up! Sorry about the wrong blame list :(
Andy Estes
Comment 9 2013-01-30 14:46:32 PST
(In reply to comment #8) > Thanks a lot for the follow up! Sorry about the wrong blame list :( That's okay, and the blame list was right (if not the specific commit) :)
Note You need to log in before you can comment on or make changes to this bug.