Wrap content filtering code in an object

• Component: New Bugs
• Status: RESOLVED FIXED

[Andy Estes]

Wrap content filtering code in an object

[Andy Estes]

Created attachment 184671 [details]
Patch

[Andy Estes]

Created attachment 184815 [details]
Patch

[Build Bot]

Comment on attachment 184815 [details]
Patch

Attachment 184815 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16113629

[Alexey Proskuryakov]

Comment on attachment 184815 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184815&action=review

> Source/WebCore/loader/MainResourceLoader.h:40
> +#include "ContentFilter.h"

Please don't include it, a forward declaration should suffice (and if it doesn't, please fix whatever is preventing it from working).

[Andy Estes]

Committed r140875: <http://trac.webkit.org/changeset/140875>

[Ryosuke Niwa]

It appears that this broke a unit test WebKit2.DownloadDecideDestinationCrash:
http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK1%20%28Tests%29/builds/4964/steps/run-api-tests/logs/stdio

Blame list: http://trac.webkit.org/log/?verbose=on&rev=140882&stop_rev=140875

[Andy Estes]

(In reply to comment #6)
> It appears that this broke a unit test WebKit2.DownloadDecideDestinationCrash:
> http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK1%20%28Tests%29/builds/4964/steps/run-api-tests/logs/stdio
> 
> Blame list: http://trac.webkit.org/log/?verbose=on&rev=140882&stop_rev=140875

This was due to some unrelated WKSI changes that got pulled in by <http://trac.webkit.org/changeset/140876/>. Alexey fixed this in <http://trac.webkit.org/changeset/141285> and the API test is no longer failing on the bot.

[Ryosuke Niwa]

(In reply to comment #7)
> (In reply to comment #6)
> > It appears that this broke a unit test WebKit2.DownloadDecideDestinationCrash:
> > http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK1%20%28Tests%29/builds/4964/steps/run-api-tests/logs/stdio
> > 
> > Blame list: http://trac.webkit.org/log/?verbose=on&rev=140882&stop_rev=140875
> 
> This was due to some unrelated WKSI changes that got pulled in by <http://trac.webkit.org/changeset/140876/>. Alexey fixed this in <http://trac.webkit.org/changeset/141285> and the API test is no longer failing on the bot.

Thanks a lot for the follow up! Sorry about the wrong blame list :(

[Andy Estes]

(In reply to comment #8)
> Thanks a lot for the follow up! Sorry about the wrong blame list :(

That's okay, and the blame list was right (if not the specific commit) :)