Bug 107906

Summary:

Remove InjectedScript::wrapSerializedObject()

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

Web Inspector (Deprecated)

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Kentaro Hara

Reported 2013-01-24 20:38:32 PST

InjectedScript::wrapSerializedObject() is unused. (This is one of steps to remove raw pointers of SerializedScriptValue*, which can be a security concern.)

Attachments
Patch (2.51 KB, patch) 2013-01-24 20:39 PST, Kentaro Hara	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kentaro Hara

Comment 1 2013-01-24 20:39:26 PST

Created attachment 184648 [details] Patch

WebKit Review Bot

Comment 2 2013-01-24 21:17:07 PST

Comment on attachment 184648 [details] Patch Rejecting attachment 184648 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 184648, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: '--force', '--reviewer', 'Abhishek Arya']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Parsed 3 diffs from patch file(s). patch: **** Can't create file /tmp/ppASo4DP : No space left on device patch: **** Can't create file /tmp/ppSg77tQ : No space left on device patch: **** Can't create file /tmp/pp0k6J6P : No space left on device Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Abhishek Arya']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16113179

WebKit Review Bot

Comment 3 2013-01-24 22:06:31 PST

Comment on attachment 184648 [details] Patch Rejecting attachment 184648 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 184648, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: '--force', '--reviewer', 'Abhishek Arya']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Parsed 3 diffs from patch file(s). patch: **** Can't create file /tmp/ppf8pxge : No space left on device patch: **** Can't create file /tmp/ppoggeWd : No space left on device patch: **** Can't create file /tmp/ppC8izJe : No space left on device Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Abhishek Arya']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16110508

WebKit Review Bot

Comment 4 2013-01-25 17:43:31 PST

Comment on attachment 184648 [details] Patch Clearing flags on attachment: 184648 Committed r140893: <http://trac.webkit.org/changeset/140893>

WebKit Review Bot

Comment 5 2013-01-25 17:43:35 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.