Bug 107889

Summary: [chromium] Remove dead transitional code from WebViewImpl
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, enne, fishd, keishi, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 107932    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
moar nomnomnoms
none
Patch none

James Robinson
Reported 2013-01-24 17:57:01 PST
[chromium] Remove dead transitional code from WebViewImpl
Attachments
Patch (3.01 KB, patch)
2013-01-24 17:57 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
moar nomnomnoms (10.70 KB, patch)
2013-01-24 18:15 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (13.02 KB, patch)
2013-01-30 17:23 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2013-01-24 17:57:57 PST
Created attachment 184624 [details] Patch
Adrienne Walker
Comment 2 2013-01-24 18:01:21 PST
Comment on attachment 184624 [details] Patch R+++++++++++, would R+ again.
James Robinson
Comment 3 2013-01-24 18:15:34 PST
Created attachment 184629 [details] moar nomnomnoms
James Robinson
Comment 4 2013-01-24 18:17:12 PST
(In reply to comment #2) > (From update of attachment 184624 [details]) > R+++++++++++, would R+ again. Added some more, PTAL. After this, some of this interface can start being removed from WebLayerTreeView completely.
WebKit Review Bot
Comment 5 2013-01-24 18:20:34 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adrienne Walker
Comment 6 2013-01-24 18:49:44 PST
Comment on attachment 184629 [details] moar nomnomnoms R=me.
WebKit Review Bot
Comment 7 2013-01-24 20:58:28 PST
Comment on attachment 184629 [details] moar nomnomnoms Clearing flags on attachment: 184629 Committed r140774: <http://trac.webkit.org/changeset/140774>
WebKit Review Bot
Comment 8 2013-01-24 20:58:33 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 9 2013-01-25 02:59:27 PST
Re-opened since this is blocked by bug 107932
Keishi Hattori
Comment 10 2013-01-25 03:01:08 PST
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@ToT - chromium.org&testType=webkit_unit_tests&tests=ScrollingCoordinatorChromiumTest.fastScrollingByDefault,ScrollingCoordinatorChromiumTest.fastScrollingForFixedPosition
James Robinson
Comment 11 2013-01-25 16:58:36 PST
(In reply to comment #10) > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@ToT - chromium.org&testType=webkit_unit_tests&tests=ScrollingCoordinatorChromiumTest.fastScrollingByDefault,ScrollingCoordinatorChromiumTest.fastScrollingForFixedPosition Sorry for breaking this! Looks like this patch breaks some of the webkit_unit_tests that only run in static builds, not component, and I forgot to test that configuration. Will figure out and post an updated patch...
James Robinson
Comment 12 2013-01-30 17:23:22 PST
Created attachment 185632 [details] Patch
Adam Barth
Comment 13 2013-01-30 23:53:04 PST
Comment on attachment 185632 [details] Patch rs=me based on enne's comments above.
WebKit Review Bot
Comment 14 2013-01-31 09:45:42 PST
Comment on attachment 185632 [details] Patch Clearing flags on attachment: 185632 Committed r141428: <http://trac.webkit.org/changeset/141428>
WebKit Review Bot
Comment 15 2013-01-31 09:45:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.