Bug 107879

Summary: Move Authentication and Downloads from WebProcess to Shared
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1 andersca: review+

Brady Eidson
Reported 2013-01-24 16:43:09 PST
Move Authentication and Downloads from WebProcess to Shared They're now used in multiple processes (Web, Network, and I'm working on using them in the UIProcess) so they belong in the Shared folder.
Attachments
Patch v1 (217.96 KB, patch)
2013-01-24 16:53 PST, Brady Eidson 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2013-01-24 16:53:22 PST
Created attachment 184613 [details] Patch v1 Rubberstampable, hopefully
Brady Eidson
Comment 2 2013-01-24 17:00:42 PST
http://trac.webkit.org/changeset/140752
Ryosuke Niwa
Comment 3 2013-01-24 17:49:42 PST
I think this patch broke Mac builds: make: *** No rule to make target `AuthenticationManagerMessageReceiver.cpp', needed by `all'. Stop. Command /bin/sh failed with exit code 2
Ryosuke Niwa
Comment 4 2013-01-24 17:58:03 PST
(In reply to comment #3) > I think this patch broke Mac builds: > > make: *** No rule to make target `AuthenticationManagerMessageReceiver.cpp', needed by `all'. Stop. > Command /bin/sh failed with exit code 2 Never mind. It seems like this was an issue with my local build files.
Ryosuke Niwa
Comment 5 2013-01-24 18:32:36 PST
Actually, it reproduced. Landed the fix suggested by andersca in http://trac.webkit.org/changeset/140762.
Brady Eidson
Comment 6 2013-01-25 07:55:38 PST
Sorry bout that (Didn't effect my build either, but I see why too!)
Ryosuke Niwa
Comment 7 2013-01-25 10:40:23 PST
(In reply to comment #6) > Sorry bout that (Didn't effect my build either, but I see why too!) It worked on bots too so it's either some xcode setting or incremental build thing.
Note You need to log in before you can comment on or make changes to this bug.