Summary: | [Chromium] IndexedDB: Let callers specify reason (error) for aborting transaction | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joshua Bell <jsbell> | ||||
Component: | New Bugs | Assignee: | Joshua Bell <jsbell> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, alecflett, dglazkov, dgrogan, fishd, jamesr, tkent+wkapi, tony, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Joshua Bell
2013-01-24 11:50:24 PST
Created attachment 184548 [details]
Patch
alecflett@ - pretty generic plumbing. Can you take a look? As a follow-up we may remove the abort()-with-no-reason overload, which is only used by script that calls abort() explicitly. Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 184548 [details]
Patch
lgtm
abarth@ - WebKit/chromium/public API change approval? tony@ - overall review? The follow-up Chromium patch (with test) is in: https://codereview.chromium.org/12035081/ ping abarth@, fishd@ or dglazkov@ - review WebKit/chromium/public API change? Comment on attachment 184548 [details]
Patch
API change LGTM
(Sorry for the delay.) Comment on attachment 184548 [details] Patch Clearing flags on attachment: 184548 Committed r141128: <http://trac.webkit.org/changeset/141128> All reviewed patches have been landed. Closing bug. |