Bug 107851

Summary: [Chromium] IndexedDB: Let callers specify reason (error) for aborting transaction
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alecflett, dglazkov, dgrogan, fishd, jamesr, tkent+wkapi, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Joshua Bell
Reported 2013-01-24 11:50:24 PST
[Chromium] IndexedDB: Let callers specify reason (error) for aborting transaction
Attachments
Patch (12.87 KB, patch)
2013-01-24 12:00 PST, Joshua Bell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2013-01-24 12:00:12 PST
Created attachment 184548 [details] Patch
Joshua Bell
Comment 2 2013-01-24 12:01:08 PST
alecflett@ - pretty generic plumbing. Can you take a look? As a follow-up we may remove the abort()-with-no-reason overload, which is only used by script that calls abort() explicitly.
WebKit Review Bot
Comment 3 2013-01-24 14:36:53 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Alec Flett
Comment 4 2013-01-24 15:04:41 PST
Comment on attachment 184548 [details] Patch lgtm
Joshua Bell
Comment 5 2013-01-24 15:33:44 PST
abarth@ - WebKit/chromium/public API change approval? tony@ - overall review? The follow-up Chromium patch (with test) is in: https://codereview.chromium.org/12035081/
Joshua Bell
Comment 6 2013-01-28 16:35:49 PST
ping abarth@, fishd@ or dglazkov@ - review WebKit/chromium/public API change?
Adam Barth
Comment 7 2013-01-28 17:15:22 PST
Comment on attachment 184548 [details] Patch API change LGTM
Adam Barth
Comment 8 2013-01-28 17:15:44 PST
(Sorry for the delay.)
WebKit Review Bot
Comment 9 2013-01-29 09:59:39 PST
Comment on attachment 184548 [details] Patch Clearing flags on attachment: 184548 Committed r141128: <http://trac.webkit.org/changeset/141128>
WebKit Review Bot
Comment 10 2013-01-29 09:59:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.