Bug 107851

Summary: [Chromium] IndexedDB: Let callers specify reason (error) for aborting transaction
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: New BugsAssignee: Joshua Bell <jsbell>
Severity: Normal CC: abarth, alecflett, dglazkov, dgrogan, fishd, jamesr, tkent+wkapi, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Joshua Bell 2013-01-24 11:50:24 PST
[Chromium] IndexedDB: Let callers specify reason (error) for aborting transaction
Comment 1 Joshua Bell 2013-01-24 12:00:12 PST
Created attachment 184548 [details]
Comment 2 Joshua Bell 2013-01-24 12:01:08 PST
alecflett@ - pretty generic plumbing. Can you take a look?

As a follow-up we may remove the abort()-with-no-reason overload, which is only used by script that calls abort() explicitly.
Comment 3 WebKit Review Bot 2013-01-24 14:36:53 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Alec Flett 2013-01-24 15:04:41 PST
Comment on attachment 184548 [details]

Comment 5 Joshua Bell 2013-01-24 15:33:44 PST
abarth@ - WebKit/chromium/public API change approval?
tony@ - overall review?

The follow-up Chromium patch (with test) is in: https://codereview.chromium.org/12035081/
Comment 6 Joshua Bell 2013-01-28 16:35:49 PST
ping abarth@, fishd@ or dglazkov@ - review WebKit/chromium/public API change?
Comment 7 Adam Barth 2013-01-28 17:15:22 PST
Comment on attachment 184548 [details]

API change LGTM
Comment 8 Adam Barth 2013-01-28 17:15:44 PST
(Sorry for the delay.)
Comment 9 WebKit Review Bot 2013-01-29 09:59:39 PST
Comment on attachment 184548 [details]

Clearing flags on attachment: 184548

Committed r141128: <http://trac.webkit.org/changeset/141128>
Comment 10 WebKit Review Bot 2013-01-29 09:59:43 PST
All reviewed patches have been landed.  Closing bug.