Bug 107790

Summary: There are a few of wrong removeAllChildren() call
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: DOMAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: adamk, darin, esprehn, mifenton, ojan.autocc, rniwa, tkent, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 107640    
Attachments:
Description Flags
Patch none

Hajime Morrita
Reported 2013-01-23 23:03:25 PST
This is from bug 107640.
Attachments
Patch (5.61 KB, patch)
2013-01-23 23:13 PST, Hajime Morrita
no flags
Hajime Morrita
Comment 1 2013-01-23 23:13:41 PST
WebKit Review Bot
Comment 2 2013-01-24 00:24:46 PST
Comment on attachment 184412 [details] Patch Clearing flags on attachment: 184412 Committed r140659: <http://trac.webkit.org/changeset/140659>
WebKit Review Bot
Comment 3 2013-01-24 00:24:49 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2013-01-24 00:26:44 PST
Darin Adler
Comment 5 2013-01-24 11:49:04 PST
Seems critical to rename removeAllChildren so future programmers don’t make the same mistake.
Ryosuke Niwa
Comment 6 2013-01-24 11:52:17 PST
(In reply to comment #5) > Seems critical to rename removeAllChildren so future programmers don’t make the same mistake. This was split off from that effort: https://bugs.webkit.org/show_bug.cgi?id=107640.
Note You need to log in before you can comment on or make changes to this bug.