Bug 107790

Summary:

There are a few of wrong removeAllChildren() call

Product:

WebKit

Reporter:

Hajime Morrita <morrita>

Component:

DOM

Assignee:

Hajime Morrita <morrita>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adamk, darin, esprehn, mifenton, ojan.autocc, rniwa, tkent, webkit-bug-importer, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

107640

Attachments:

Description	Flags
Patch	none

Description Hajime Morrita 2013-01-23 23:03:25 PST

This is from  bug 107640.

Comment 1 Hajime Morrita 2013-01-23 23:13:41 PST

Created attachment 184412 [details]
Patch

Comment 2 WebKit Review Bot 2013-01-24 00:24:46 PST

Comment on attachment 184412 [details]
Patch

Clearing flags on attachment: 184412

Committed r140659: <http://trac.webkit.org/changeset/140659>

Comment 3 WebKit Review Bot 2013-01-24 00:24:49 PST

All reviewed patches have been landed.  Closing bug.

Comment 4 Radar WebKit Bug Importer 2013-01-24 00:26:44 PST

<rdar://problem/13076849>

Comment 5 Darin Adler 2013-01-24 11:49:04 PST

Seems critical to rename removeAllChildren so future programmers don’t make the same mistake.

Comment 6 Ryosuke Niwa 2013-01-24 11:52:17 PST

(In reply to comment #5)
> Seems critical to rename removeAllChildren so future programmers don’t make the same mistake.

This was split off from that effort: https://bugs.webkit.org/show_bug.cgi?id=107640.