Bug 107771

Summary:

[svg] Remove unnecessary rounding in SVGRootInlineBox::layoutRootBox

Product:

WebKit

Reporter:

Emil A Eklund <eae>

Component:

SVG

Assignee:

Emil A Eklund <eae>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

d-r, eric, fmalita, ojan.autocc, pdr, rniwa, schenney, webkit.review.bot, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Emil A Eklund

Reported 2013-01-23 18:01:36 PST

SVGRootInlineBox::layoutRootBox rounds the location and size of the container to the nearest enclosing integer values. Now that layout uses subpixel positioning this is no longer needed and results in undesirable rounding. For high-dpi screens in particular this is especially noticeable as it is rounded to "pixels" which can map to two our more device pixels. Downstream chromium bug: http://code.google.com/p/chromium/issues/detail?id=165929

Attachments
Patch (1.56 MB, patch) 2013-01-23 18:06 PST, Emil A Eklund	no flags	Details Formatted Diff Diff
Patch (107.55 KB, patch) 2013-01-24 14:12 PST, Emil A Eklund	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Emil A Eklund

Comment 1 2013-01-23 18:06:46 PST

Created attachment 184370 [details] Patch

WebKit Review Bot

Comment 2 2013-01-23 18:17:58 PST

Attachment 184370 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3/zoom-coords.xhtml', u'LayoutTests/platform/chromium-linux/css3/zoom-coords-expected.txt', u'LayoutTests/platform/chromium-linux/platform/chromium-linux/svg/text/text-with-geometric-precision-expected.txt', u'LayoutTests/platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt', u'LayoutTests/platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt', u'LayoutTests/platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt', u'LayoutTests/platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt', u'LayoutTests/platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt', u'LayoutTests/platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt', u'LayoutTests/platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt', u'LayoutTests/platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt', u'LayoutTests/platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt', u'LayoutTests/platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt', u'LayoutTests/platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt', u'LayoutTests/platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt', u'LayoutTests/platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.txt', u'LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt', u'LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt', u'LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt', u'LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt', u'LayoutTests/platform/chromium-linux/svg/batik/text/textFeatures-expected.png', u'LayoutTests/platform/chromium-linux/svg/batik/text/xmlSpace-expected.txt', u'LayoutTests/platform/chromium-linux/svg/carto.net/scrollbar-expected.txt', u'LayoutTests/platform/chromium-linux/svg/carto.net/tabgroup-expected.png', u'LayoutTests/platform/chromium-linux/svg/carto.net/tabgroup-expected.txt', u'LayoutTests/platform/chromium-linux/svg/custom/js-late-gradient-and-object-creation-expected.png', u'LayoutTests/platform/chromium-linux/svg/custom/js-late-gradient-creation-expected.png', u'LayoutTests/platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.png', u'LayoutTests/platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.png', u'LayoutTests/platform/chromium-linux/svg/custom/use-modify-target-symbol-expected.txt', u'LayoutTests/platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.txt', u'LayoutTests/platform/chromium-linux/svg/text/bidi-tspans-expected.txt', u'LayoutTests/platform/chromium-linux/svg/text/modify-text-node-in-tspan-expected.png', u'LayoutTests/platform/chromium-linux/svg/text/remove-text-node-from-tspan-expected.png', u'LayoutTests/platform/chromium-linux/svg/text/remove-tspan-from-text-expected.png', u'LayoutTests/platform/chromium-linux/svg/text/selection-doubleclick-expected.txt', u'LayoutTests/platform/chromium-linux/svg/text/text-fonts-01-t-expected.txt', u'LayoutTests/platform/chromium-linux/svg/text/text-fonts-02-t-expected.txt', u'LayoutTests/platform/chromium-linux/svg/text/text-intro-05-t-expected.txt', u'LayoutTests/platform/chromium-linux/svg/text/text-rect-precision-expected.txt', u'LayoutTests/platform/chromium-linux/svg/text/text-spacing-01-b-expected.txt', u'LayoutTests/platform/chromium-linux/svg/text/text-text-08-b-expected.txt', u'LayoutTests/platform/chromium-linux/svg/transforms/text-with-mask-with-svg-transform-expected.txt', u'LayoutTests/platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png', u'LayoutTests/platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt', u'LayoutTests/platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.txt', u'LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt', u'LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/text-align-02-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/text-align-04-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/text-align-05-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/text-align-08-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/text-path-01-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/text-text-01-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/text-text-06-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/filters/feTile-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/filters/filterRegions-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/masking/maskRegions-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/paints/gradientLimit-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/text/smallFonts-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/text/textAnchor-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/text/textAnchor2-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/text/textAnchor3-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/text/textEffect-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/text/textEffect3-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/text/textFeatures-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/text/textLayout-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/text/textLayout2-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/text/textLength-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/text/textOnPath-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/text/textOnPath2-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/text/textOnPath3-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/text/textPCDATA-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/text/textProperties-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/text/textStyles-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/text/verticalText-expected.txt', u'LayoutTests/platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.txt', u'LayoutTests/platform/chromium-win/svg/carto.net/button-expected.txt', u'LayoutTests/platform/chromium-win/svg/carto.net/colourpicker-expected.txt', u'LayoutTests/platform/chromium-win/svg/carto.net/combobox-expected.txt', u'LayoutTests/platform/chromium-win/svg/carto.net/selectionlist-expected.txt', u'LayoutTests/platform/chromium-win/svg/carto.net/slider-expected.txt', u'LayoutTests/platform/chromium-win/svg/carto.net/textbox-expected.txt', u'LayoutTests/platform/chromium-win/svg/carto.net/window-expected.txt', u'LayoutTests/platform/chromium-win/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt', u'LayoutTests/platform/chromium-win/svg/clip-path/deep-nested-clip-in-mask-expected.txt', u'LayoutTests/platform/chromium-win/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt', u'LayoutTests/platform/chromium-win/svg/css/text-shadow-multiple-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/dominant-baseline-hanging-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/dominant-baseline-modes-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/font-face-cascade-order-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/font-face-simple-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/image-small-width-height-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/invalid-css-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/js-late-clipPath-and-object-creation-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/js-late-clipPath-creation-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/js-late-gradient-creation-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/js-late-pattern-creation-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/linking-uri-01-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/marker-default-width-height-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/path-textPath-simulation-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/pointer-events-text-css-transform-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/shapes-supporting-markers-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/stroked-pattern-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/text-letter-spacing-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/text-tref-03-b-change-href-dom-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/text-tref-03-b-change-href-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/text-tref-03-b-referenced-element-removal-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/text-tref-03-b-tref-removal-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/text-x-dx-lists-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/text-x-override-in-tspan-child-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/tref-own-content-removal-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/tref-update-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/use-detach-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/use-modify-container-in-target-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/use-modify-target-container-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/use-on-g-containing-symbol-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/use-on-g-containing-use-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/use-on-g-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/use-on-rect-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/use-on-symbol-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/use-on-text-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/use-on-use-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/use-recursion-1-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/use-recursion-2-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/use-recursion-3-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/use-recursion-4-expected.txt', u'LayoutTests/platform/chromium-win/svg/custom/use-transform-expected.txt', u'LayoutTests/platform/chromium-win/svg/hixie/perf/003-expected.txt', u'LayoutTests/platform/chromium-win/svg/hixie/perf/004-expected.txt', u'LayoutTests/platform/chromium-win/svg/hixie/perf/005-expected.txt', u'LayoutTests/platform/chromium-win/svg/hixie/perf/006-expected.txt', u'LayoutTests/platform/chromium-win/svg/hixie/text/003-expected.txt', u'LayoutTests/platform/chromium-win/svg/hixie/text/003b-expected.txt', u'LayoutTests/platform/chromium-win/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt', u'LayoutTests/platform/chromium-win/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/append-text-node-to-tspan-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/bidi-reorder-value-lists-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/bidi-text-anchor-direction-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/bidi-text-query-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/font-size-below-point-five-2-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/remove-text-node-from-tspan-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/scaled-font-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/scaling-font-with-geometric-precision-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-textLength-spacing-squeeze-1-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-textLength-spacing-squeeze-3-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-textLength-spacing-squeeze-4-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-textLength-spacing-stretch-1-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-textLength-spacing-stretch-2-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-textLength-spacing-stretch-3-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-textLength-spacing-stretch-4-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-x-list-1-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-x-list-2-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-x-list-3-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-x-list-4-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-x-list-with-tspans-1-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-x-list-with-tspans-2-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-x-list-with-tspans-3-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/select-x-list-with-tspans-4-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/selection-tripleclick-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/small-fonts-2-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/small-fonts-3-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/small-fonts-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/small-fonts-in-html5-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/text-align-01-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/text-align-02-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/text-align-03-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/text-align-04-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/text-align-05-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/text-align-06-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/text-altglyph-01-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/text-deco-01-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/text-path-01-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/text-path-middle-align-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/text-text-01-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/text-text-03-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/text-text-04-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/text-text-05-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/text-text-06-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/text-text-07-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/text-tref-01-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/text-tselect-01-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/text-tselect-02-f-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/text-tspan-01-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/text-ws-01-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/text/text-ws-02-t-expected.txt', u'LayoutTests/platform/chromium-win/svg/wicd/rightsizing-grid-expected.txt', u'LayoutTests/platform/chromium-win/svg/wicd/test-rightsizing-a-expected.txt', u'LayoutTests/platform/chromium-win/svg/wicd/test-rightsizing-b-expected.txt', u'LayoutTests/platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.txt', u'LayoutTests/platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt', u'LayoutTests/platform/chromium-win/svg/zoom/text/zoom-foreignObject-expected.txt', u'LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt', u'LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt', u'LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt', u'LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt', u'LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt', u'LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt', u'LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt', u'LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt', u'LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt', u'LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt', u'LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt', u'LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt', u'LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt', u'LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt', u'LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt', u'LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt', u'LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt', u'LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt', u'LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt', u'LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt', u'LayoutTests/platform/chromium/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt', u'LayoutTests/platform/chromium/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt', u'LayoutTests/platform/chromium/svg/custom/clip-mask-negative-scale-expected.txt', u'LayoutTests/platform/chromium/svg/hixie/text/001-expected.txt', u'LayoutTests/platform/chromium/svg/hixie/text/003a-expected.txt', u'LayoutTests/platform/chromium/svg/text/modify-text-node-in-tspan-expected.txt', u'LayoutTests/platform/chromium/svg/text/remove-tspan-from-text-expected.txt', u'LayoutTests/platform/chromium/svg/text/text-hkern-expected.txt', u'LayoutTests/platform/chromium/svg/wicd/sizing-flakiness-expected.txt', u'LayoutTests/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt', u'LayoutTests/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt', u'LayoutTests/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt', u'LayoutTests/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt', u'LayoutTests/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt', u'LayoutTests/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt', u'LayoutTests/svg/custom/glyph-setting-d-attribute-expected.txt', u'LayoutTests/svg/foreignObject/text-tref-02-b-expected.txt', u'LayoutTests/svg/hixie/viewbox/002-expected.txt', u'LayoutTests/svg/hixie/viewbox/003-expected.txt', u'LayoutTests/svg/text/text-rect-precision.html', u'LayoutTests/svg/text/text-viewbox-rescale-expected.txt', u'LayoutTests/svg/zoom/page/zoom-zoom-coords-expected.txt', u'LayoutTests/svg/zoom/page/zoom-zoom-coords.xhtml', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/svg/SVGRootInlineBox.cpp']" exit_code: 1 LayoutTests/platform/chromium-linux/svg/text/modify-text-node-in-tspan-expected.png:0: Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png"). [image/png] [5] Total errors found: 1 in 371 files If any of these errors are false positives, please file a bug against check-webkit-style.

Stephen Chenney

Comment 3 2013-01-24 05:53:25 PST

LGTM, but I'm not a reviewer.

Levi Weintraub

Comment 4 2013-01-24 10:35:58 PST

Comment on attachment 184370 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184370&action=review > Source/WebCore/rendering/svg/SVGRootInlineBox.cpp:174 > - IntRect roundedChildRect = enclosingIntRect(childRect); > + LayoutRect roundedChildRect = enclosingLayoutRect(childRect); This looks good, but I don't like the name roundedChildRect. It seems misleading after this change.

Emil A Eklund

Comment 5 2013-01-24 10:50:04 PST

(In reply to comment #4) > (From update of attachment 184370 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=184370&action=review > > > Source/WebCore/rendering/svg/SVGRootInlineBox.cpp:174 > > - IntRect roundedChildRect = enclosingIntRect(childRect); > > + LayoutRect roundedChildRect = enclosingLayoutRect(childRect); > > This looks good, but I don't like the name roundedChildRect. It seems misleading after this change. How about enclosingRect or boundingRect?

Emil A Eklund

Comment 6 2013-01-24 14:12:23 PST

Created attachment 184576 [details] Patch

Emil A Eklund

Comment 7 2013-01-24 14:50:16 PST

Committed r140728: <http://trac.webkit.org/changeset/140728>

Ryosuke Niwa

Comment 8 2013-01-25 00:49:28 PST

This patch added svg/text/text-rect-precision.html but didn't add any expected result for it. How does that work?

Note You need to log in before you can comment on or make changes to this bug.