Bug 107729

Summary: Layout Test platform/chromium-win/fast/events/panScroll-panIcon.html is failing
Product: WebKit Reporter: Erik Arvidsson <arv>
Component: Tools / TestsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, morrita, yosin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch 1
none
Patch 2
none
Patch 4
none
Patch 5 none

Description Erik Arvidsson 2013-01-23 13:48:44 PST 
The following layout test is failing on Win7, XP

platform/chromium-win/fast/events/panScroll-panIcon.html

Probable cause:

https://bugs.webkit.org/show_bug.cgi?id=107623
Comment 1 James Robinson 2013-01-23 15:56:11 PST 
The pixel test is verifying that there's no pan scroll icon visible at the end of the test, which is true.  The thumb size in the -actual.pngs looks about right to me, I think this just needs a rebase.  Perhaps the test content was changed in between the time the -expected.png was generated and the test landed to have less overflow?
Comment 2 yosin 2013-01-23 17:20:19 PST 
It seems we can use HTML expectation file rather than pixel image.
Comment 3 yosin 2013-01-23 20:31:41 PST 
Created attachment 184389 [details]
Patch 1
Comment 4 yosin 2013-01-23 20:36:00 PST 
Created attachment 184390 [details]
Patch 2
Comment 5 yosin 2013-01-23 20:40:16 PST 
Created attachment 184391 [details]
Patch 4
Comment 6 yosin 2013-01-23 20:41:00 PST 
Comment on attachment 184391 [details]
Patch 4

Could you review this patch?
Thanks in advance.
Comment 7 Hajime Morrita 2013-01-23 20:42:44 PST 
Comment on attachment 184390 [details]
Patch 2

Can we get rid of the script and make it plain HTML? It would be easy to investigate.
Comment 8 yosin 2013-01-23 21:29:26 PST 
Created attachment 184396 [details]
Patch 5
Comment 9 yosin 2013-01-23 21:31:57 PST 
Comment on attachment 184396 [details]
Patch 5

Clearing flags on attachment: 184396

Committed r140647: <http://trac.webkit.org/changeset/140647>
Comment 10 yosin 2013-01-23 21:32:01 PST 
All reviewed patches have been landed.  Closing bug.
Comment 11 Erik Arvidsson 2013-01-24 07:23:38 PST 
Thanks