Bug 107717

Summary: Assert that Supplementable objects are only used in their creator thread
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: WebCore Misc.Assignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
The patch. abarth: review+

Mark Lam
Reported 2013-01-23 12:18:42 PST
Supplementable and Supplement instances should only be used in the thread that created them. Adding an assertion to help detect when someone is unknowingly violating this design premise.
Attachments
The patch. (2.91 KB, patch)
2013-01-23 12:29 PST, Mark Lam 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2013-01-23 12:29:54 PST
Created attachment 184282 [details] The patch.
Adam Barth
Comment 2 2013-01-23 13:16:08 PST
Comment on attachment 184282 [details] The patch. View in context: https://bugs.webkit.org/attachment.cgi?id=184282&action=review > Source/WebCore/platform/Supplementable.h:128 > + ThreadIdentifier m_threadId; I wonder if this is the right thing for code that uses libdispatch. I think there's some other notion of thread affinity that we're supposed to use in those cases.
Mark Lam
Comment 3 2013-01-23 13:28:40 PST
Landed in r140580: <http://trac.webkit.org/changeset/140580>
Note You need to log in before you can comment on or make changes to this bug.