Bug 107696

Summary: [Qt][WK1] Support better testing of Web Notifications
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: Tools / TestsAssignee: Allan Sandfeld Jensen <allan.jensen>
Severity: Normal CC: webkit.review.bot, zarvai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95507, 107449    
Description Flags
Patch none

Description Allan Sandfeld Jensen 2013-01-23 08:05:48 PST
To be able to run more of the web notification tests, we need to implement these methods in DRT:

void denyWebNotificationPermission(in DOMString origin);
void removeAllWebNotificationPermissions();
Comment 1 Allan Sandfeld Jensen 2013-01-23 08:11:21 PST
Created attachment 184240 [details]
Comment 2 Jocelyn Turcotte 2013-01-24 06:17:30 PST
Comment on attachment 184240 [details]

Overall comments
Comment 3 WebKit Review Bot 2013-01-30 06:00:37 PST
Comment on attachment 184240 [details]

Clearing flags on attachment: 184240

Committed r141259: <http://trac.webkit.org/changeset/141259>
Comment 4 WebKit Review Bot 2013-01-30 06:00:41 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Zoltan Arvai 2013-01-30 06:21:51 PST
Qt Linux Release minimal has some problem with the patch:

/ramdisk/qt-linux-release-minimal/build/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp: In static member function 'static void DumpRenderTreeSupportQt::clearNotificationPermissions()':
/ramdisk/qt-linux-release-minimal/build/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:1072: error: 'WebCore::NotificationPresenterClientQt' has not been declared


Can you check it, please?