Bug 107696

Summary: [Qt][WK1] Support better testing of Web Notifications
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: Tools / TestsAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot, zarvai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95507, 107449    
Attachments:
Description Flags
Patch none

Allan Sandfeld Jensen
Reported 2013-01-23 08:05:48 PST
To be able to run more of the web notification tests, we need to implement these methods in DRT: void denyWebNotificationPermission(in DOMString origin); void removeAllWebNotificationPermissions();
Attachments
Patch (15.63 KB, patch)
2013-01-23 08:11 PST, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2013-01-23 08:11:21 PST
Created attachment 184240 [details] Patch
Jocelyn Turcotte
Comment 2 2013-01-24 06:17:30 PST
Comment on attachment 184240 [details] Patch Overall comments
WebKit Review Bot
Comment 3 2013-01-30 06:00:37 PST
Comment on attachment 184240 [details] Patch Clearing flags on attachment: 184240 Committed r141259: <http://trac.webkit.org/changeset/141259>
WebKit Review Bot
Comment 4 2013-01-30 06:00:41 PST
All reviewed patches have been landed. Closing bug.
Zoltan Arvai
Comment 5 2013-01-30 06:21:51 PST
Qt Linux Release minimal has some problem with the patch: /ramdisk/qt-linux-release-minimal/build/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp: In static member function 'static void DumpRenderTreeSupportQt::clearNotificationPermissions()': /ramdisk/qt-linux-release-minimal/build/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:1072: error: 'WebCore::NotificationPresenterClientQt' has not been declared http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/70733 Can you check it, please?
Note You need to log in before you can comment on or make changes to this bug.