Summary: | [Qt][WK1] Support better testing of Web Notifications | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Allan Sandfeld Jensen <allan.jensen> | ||||
Component: | Tools / Tests | Assignee: | Allan Sandfeld Jensen <allan.jensen> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot, zarvai | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 95507, 107449 | ||||||
Attachments: |
|
Description
Allan Sandfeld Jensen
2013-01-23 08:05:48 PST
Created attachment 184240 [details]
Patch
Comment on attachment 184240 [details]
Patch
Overall comments
Comment on attachment 184240 [details] Patch Clearing flags on attachment: 184240 Committed r141259: <http://trac.webkit.org/changeset/141259> All reviewed patches have been landed. Closing bug. Qt Linux Release minimal has some problem with the patch: /ramdisk/qt-linux-release-minimal/build/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp: In static member function 'static void DumpRenderTreeSupportQt::clearNotificationPermissions()': /ramdisk/qt-linux-release-minimal/build/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:1072: error: 'WebCore::NotificationPresenterClientQt' has not been declared http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/70733 Can you check it, please? |