Summary: | [Qt][WK1] Remember denied permission for notifications | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Allan Sandfeld Jensen <allan.jensen> | ||||
Component: | WebKit Qt | Assignee: | Allan Sandfeld Jensen <allan.jensen> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | jturcotte, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 107449 | ||||||
Attachments: |
|
Description
Allan Sandfeld Jensen
2013-01-23 07:50:21 PST
Created attachment 184236 [details]
Patch
Comment on attachment 184236 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184236&action=review > Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp:424 > - callback->handleEvent(Notification::permissionString(NotificationClient::PermissionAllowed)); > + callback->handleEvent(Notification::permissionString(permission)); Is this a patch split artifact? Comment on attachment 184236 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184236&action=review >> Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp:424 >> + callback->handleEvent(Notification::permissionString(permission)); > > Is this a patch split artifact? Looks good to me otherwise, please remove this before landing. (In reply to comment #2) > (From update of attachment 184236 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=184236&action=review > > > Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp:424 > > - callback->handleEvent(Notification::permissionString(NotificationClient::PermissionAllowed)); > > + callback->handleEvent(Notification::permissionString(permission)); > > Is this a patch split artifact? No that is correct. This method was renamed to be able to both approve and reject permissions. Comment on attachment 184236 [details] Patch Rejecting attachment 184236 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 184236, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: create file /tmp/pp3OGHLx : No space left on device patch: **** Can't create file /tmp/ppNkY7VA : No space left on device patch: **** Can't create file /tmp/ppR4mo8A : No space left on device patch: **** Can't create file /tmp/pp1eYnHA : No space left on device patch: **** Can't create file /tmp/ppzAoqwB : No space left on device Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Jocelyn Turcotte']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16110081 (In reply to comment #4) > No that is correct. This method was renamed to be able to both approve and reject permissions. Alright, I see it now. Comment on attachment 184236 [details] Patch Clearing flags on attachment: 184236 Committed r141233: <http://trac.webkit.org/changeset/141233> All reviewed patches have been landed. Closing bug. |