Bug 107691

Summary: REGRESSION(r140518): Broke Chromium Win build (gyp file not updated) (Requested by arv on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: kenneth, noam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 105847    
Attachments:
Description Flags
ROLLOUT of r140518
none
Patch for landing none

WebKit Review Bot
Reported 2013-01-23 07:37:05 PST
http://trac.webkit.org/changeset/140518 broke the build: Broke Chromium Win build (gyp file not updated) (Requested by arv on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r140518 (56.60 KB, patch)
2013-01-23 07:37 PST, WebKit Review Bot 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.56 KB, patch)
2013-01-23 08:00 PST, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2013-01-23 07:37:37 PST
Created attachment 184230 [details] ROLLOUT of r140518 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Erik Arvidsson
Comment 2 2013-01-23 07:53:37 PST
Comment on attachment 184230 [details] ROLLOUT of r140518 I'll let noam update the gyp file
Noam Rosenthal
Comment 3 2013-01-23 08:00:56 PST
Created attachment 184237 [details] Patch for landing
WebKit Review Bot
Comment 4 2013-01-23 10:43:39 PST
Comment on attachment 184237 [details] Patch for landing Clearing flags on attachment: 184237 Committed r140547: <http://trac.webkit.org/changeset/140547>
WebKit Review Bot
Comment 5 2013-01-23 10:43:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.