Bug 107653

Summary: [WK2] Add applyDeviceScaleFactorInCompositor and applyPageScaleFactorInCompositor APIs to WebPreferences.
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: WebKit2Assignee: Dongseong Hwang <dongseong.hwang>
Status: RESOLVED INVALID    
Severity: Normal CC: andersca, benjamin, kenneth, mikhail.pozdnyakov, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 105978    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Dongseong Hwang
Reported 2013-01-23 02:20:54 PST
EFL and Qt will use this preferences.
Attachments
Patch (3.59 KB, patch)
2013-01-23 02:26 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Patch (34.03 KB, patch)
2013-01-23 03:39 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Patch (3.63 KB, patch)
2013-01-23 21:49 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dongseong Hwang
Comment 1 2013-01-23 02:26:31 PST
Created attachment 184185 [details] Patch
Dongseong Hwang
Comment 2 2013-01-23 03:39:57 PST
Created attachment 184192 [details] Patch
Sam Weinig
Comment 3 2013-01-23 17:04:17 PST
Comment on attachment 184185 [details] Patch This doesn't actually expose the preference to API and you also have not explained what this would be used for and why it is necessary.
Dongseong Hwang
Comment 4 2013-01-23 21:40:25 PST
(In reply to comment #3) > (From update of attachment 184185 [details]) > This doesn't actually expose the preference to API and you also have not explained what this would be used for and why it is necessary. It is very reasonable concern. I did block Bug 105978 that uses this preference, but I did not explain enough. sorry for that. EFL and Qt want to use page scale in WebCore as Chromium did. So EFL and Qt want to set applyDeviceScaleFactorInCompositor and applyPageScaleFactorInCompositor as Chromium did. EFL and Qt want to set both in UI Process, so we need to add new API in WebPreferencesStore although we don't add new API in WK2 API (WKPreferences). (I made a mistake about title.) Could we add new those APIs in WebPreferencesStore?
Dongseong Hwang
Comment 5 2013-01-23 21:49:01 PST
Created attachment 184399 [details] Patch
Kenneth Rohde Christiansen
Comment 6 2013-01-24 00:28:02 PST
(In reply to comment #3) > (From update of attachment 184185 [details]) > This doesn't actually expose the preference to API and you also have not explained what this would be used for and why it is necessary. I think the point is that it is not a user preference, but something which should be set by out view. Dongsung, is there a reason why this cannot always be set in the WebProcess, like together with turning on fixed layouting?
Dongseong Hwang
Comment 7 2013-01-24 00:40:29 PST
(In reply to comment #6) > (In reply to comment #3) > > (From update of attachment 184185 [details] [details]) > > This doesn't actually expose the preference to API and you also have not explained what this would be used for and why it is necessary. > > I think the point is that it is not a user preference, but something which should be set by out view. Dongsung, is there a reason why this cannot always be set in the WebProcess, like together with turning on fixed layouting? aha, do you mean it is fine that setting them in WebPage::setUseFixedLayout(bool fixed)? I did not do that because I did not fully understand what is FixedLayout. Ok, I see. This bug is invalid. Thank kenneth and sam.
Note You need to log in before you can comment on or make changes to this bug.