Bug 107646

Summary: REGRESSION(r140338): WebKitGtk+ trying to allocate a buffer too big
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, danw, gns, mrobinson, pnormand, rakuco, svillar, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cgarcia: review+

Description Sergio Villar Senin 2013-01-23 00:48:38 PST
REGRESSION(r140338): WebKitGtk+ trying to allocate a buffer too big
Comment 1 Sergio Villar Senin 2013-01-23 00:53:31 PST
Created attachment 184175 [details]
Patch
Comment 2 Carlos Garcia Campos 2013-01-23 01:07:36 PST
Comment on attachment 184175 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184175&action=review

Thanks

> Source/WebCore/ChangeLog:9
> +        g_input_stream_read_async() to workaround a glib buffer. The former

I guess you mean to workaround a glib bug? Assuming skip is more efficient than read, I think we could add a FIXME pointing to the glib bug to use skip again once the glib bug is fixed.
Comment 3 Sergio Villar Senin 2013-01-23 01:10:32 PST
(In reply to comment #2)
> (From update of attachment 184175 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=184175&action=review
> 
> Thanks
> 
> > Source/WebCore/ChangeLog:9
> > +        g_input_stream_read_async() to workaround a glib buffer. The former
> 
> I guess you mean to workaround a glib bug? Assuming skip is more efficient than read, I think we could add a FIXME pointing to the glib bug to use skip again once the glib bug is fixed.

Sure, it was a glib bug. I guess the FIXME had to be added in r140338 but I can add it here.
Comment 4 Sergio Villar Senin 2013-01-23 01:22:52 PST
Committed r140524: <http://trac.webkit.org/changeset/140524>