Bug 107645

Summary: Pass CSSSelector pointers around as const after parsing stage.
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cmarcelo, dglazkov, koivisto, macpherson, menard, ojan.autocc, peter+ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
atchP
eflews.bot: commit-queue-
Please, Shadow DOM, please. none

Andreas Kling
Reported 2013-01-23 00:47:53 PST
CSSSelector contents should never change after CSSParser is done with them, so we should hand them out as const pointers everywhere else.
Attachments
atchP (34.22 KB, patch)
2013-01-23 00:51 PST, Andreas Kling 		eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Please, Shadow DOM, please. (35.99 KB, patch)
2013-01-23 01:38 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-01-23 00:51:01 PST
Created attachment 184173 [details] atchP
EFL EWS Bot
Comment 2 2013-01-23 01:05:22 PST
Comment on attachment 184173 [details] atchP Attachment 184173 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16063494
WebKit Review Bot
Comment 3 2013-01-23 01:13:49 PST
Comment on attachment 184173 [details] atchP Attachment 184173 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16067263
Peter Beverloo (cr-android ews)
Comment 4 2013-01-23 01:30:07 PST
Comment on attachment 184173 [details] atchP Attachment 184173 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16073120
Andreas Kling
Comment 5 2013-01-23 01:38:34 PST
Created attachment 184179 [details] Please, Shadow DOM, please.
WebKit Review Bot
Comment 6 2013-01-23 02:27:33 PST
Comment on attachment 184179 [details] Please, Shadow DOM, please. Clearing flags on attachment: 184179 Committed r140530: <http://trac.webkit.org/changeset/140530>
WebKit Review Bot
Comment 7 2013-01-23 02:27:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.