Summary: | REGRESSION(r139044): Pan icon remains on screen on Chromium-WinXP | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | yosin | ||||||||
Component: | UI Events | Assignee: | yosin | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | arv, dglazkov, morrita, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
yosin
2013-01-22 21:11:20 PST
Import from http://crbug.com/166866 Created attachment 184136 [details]
Patch 1
Comment on attachment 184136 [details]
Patch 1
Could you review this patch? This is for fixing P1-M25-Release-Blocker.
Thanks in advance.
P.S.
Sorry for another regression on AutoscrollController. m(_ _)m
Comment on attachment 184136 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=184136&action=review > Source/WebCore/ChangeLog:14 > + No new tests. There is no way to check pan icon image in window. Is there any way we could fix this and get some tests? Created attachment 184160 [details]
Patch 2
Comment on attachment 184160 [details]
Patch 2
Could you review this patch?
Thanks in advance.
= Changes since the last review =
* Add a layout test
r? please? Attachment 184160 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/chromium-win/fast/events/panScroll-panIcon-expected.png:0: Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png"). [image/png] [5]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 184160 [details] Patch 2 Attachment 184160 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16084033 New failing tests: platform/chromium-win/fast/events/panScroll-panIcon.html Created attachment 184177 [details]
Patch 3
Comment on attachment 184177 [details]
Patch 3
Could you review this patch?
Thanks in advance.
= Changes since the last review =
* Add panScroll-panIcon.html test
* Add skip entry for chromium/TestExpectations
Attachment 184177 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/chromium-win/fast/events/panScroll-panIcon-expected.png:0: Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png"). [image/png] [5]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 184177 [details] Patch 3 Clearing flags on attachment: 184177 Committed r140525: <http://trac.webkit.org/changeset/140525> All reviewed patches have been landed. Closing bug. I'm seeing strange results on Win: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium-win%2Ffast%2Fevents%2FpanScroll-panIcon.html It does not look correct to me. The scrollbar thumb is now larger than before (about twice the height) |