Summary: | EWS creates 0 byte sized log files | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Lucas Forschler <lforschler> | ||||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, alancutter, ap, commit-queue, dpranke, eric, glenn, llango.u-szeged, ossy, rniwa | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 124782, 124783 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Lucas Forschler
2013-01-22 17:50:11 PST
They should be smaller, but not zero sized. :( We can revert the change. Created attachment 216578 [details]
Patch
Comment on attachment 216578 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216578&action=review > Tools/ChangeLog:13 > + > + * Scripts/webkitpy/tool/bot/queueengine.py: > + (QueueEngine.run): > + (QueueEngine._open_work_log): > + (QueueEngine._ensure_work_log_closed): > + * Scripts/webkitpy/tool/commands/earlywarningsystem.py: > + (AbstractEarlyWarningSystem.review_patch): I'd like to see some description as to why this bug manifested and how you fixed it. There is a lot of code change here, and the correctness of code change is not self-evident. (In reply to comment #3) > (From update of attachment 216578 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=216578&action=review > > > Tools/ChangeLog:13 > > + > > + * Scripts/webkitpy/tool/bot/queueengine.py: > > + (QueueEngine.run): > > + (QueueEngine._open_work_log): > > + (QueueEngine._ensure_work_log_closed): > > + * Scripts/webkitpy/tool/commands/earlywarningsystem.py: > > + (AbstractEarlyWarningSystem.review_patch): > > I'd like to see some description as to why this bug manifested and how you fixed it. > There is a lot of code change here, and the correctness of code change is not self-evident. There was a modification in r138264, that tried to make less log, because some of the messeges were duplicated. After this the EWS created the log file (with the same name as the bugID) but doesn't write anything into it, even if there were errors during the build. So i managed this. Now it will create the log file only if there is an error, and wont create if dont want to write anything to it. The main problem was that, the ScriptError was not raised and the QueueEngine never get that. Now it gets the error and handles it. Please add per-function/code change comment as to how you fixed that problem. Created attachment 217559 [details]
Patch
Comment on attachment 217559 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217559&action=review > Tools/ChangeLog:12 > + Reviewed by NOBODY (OOPS!). This line should appear before the long description but after the bug url. > Tools/ChangeLog:15 > + (QueueEngine.run): Open the log file only if a ScriptError was raised. Why? > Tools/ChangeLog:16 > + (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore. Why? > Tools/ChangeLog:17 > + (QueueEngine._ensure_work_log_closed): Close the logfile. Why? > Tools/ChangeLog:19 > + (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError. Why? The current change log comments simply repeats the code change. I'm looking for is an explanation as to why each code change is made. Created attachment 217684 [details]
Patch
Comment on attachment 217684 [details]
Patch
Thanks.
Comment on attachment 217684 [details] Patch Clearing flags on attachment: 217684 Committed r159690: <http://trac.webkit.org/changeset/159690> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 124782 This broke webkitpy tests, rolling out. It's not obvious whether these just need an update of results. http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK1%20(Tests)/builds/15098/steps/webkitpy-test/logs/stdio Created attachment 217777 [details]
Patch
(In reply to comment #14) > This broke webkitpy tests, rolling out. It's not obvious whether these just need an update of results. > > http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK1%20(Tests)/builds/15098/steps/webkitpy-test/logs/stdio Unfortunately i forgot to update the unit test. It really was not obvious, but this change is needed, because of the patch. I wrote some explanation into the Change log too. Comment on attachment 217777 [details] Patch Clearing flags on attachment: 217777 Committed r159749: <http://trac.webkit.org/changeset/159749> All reviewed patches have been landed. Closing bug. |