Bug 107598

Summary: Remove webkitNotifications.createHTMLNotification
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: ahmad.saleem792, benjamin, dglazkov, jonlee, mifenton, ojan.autocc, rwlbuis, syoichi, tonikitoo, webkit-bug-importer, webkit.review.bot, yong.li.webkit
Priority: P2 Keywords: InRadar, WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 108277    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Adam Barth
Reported 2013-01-22 16:40:44 PST
Remove webkitNotifications.createHTMLNotification
Attachments
Patch (36.92 KB, patch)
2013-01-22 16:46 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (41.33 KB, patch)
2013-01-22 17:08 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (43.16 KB, patch)
2013-01-28 11:14 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2013-01-22 16:46:01 PST
Created attachment 184076 [details] Patch
Benjamin Poulain
Comment 2 2013-01-22 16:56:06 PST
Comment on attachment 184076 [details] Patch Wooot! :)
Early Warning System Bot
Comment 3 2013-01-22 17:03:48 PST
Comment on attachment 184076 [details] Patch Attachment 184076 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16037874
Early Warning System Bot
Comment 4 2013-01-22 17:05:45 PST
Comment on attachment 184076 [details] Patch Attachment 184076 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16037876
Adam Barth
Comment 5 2013-01-22 17:08:37 PST
Created attachment 184086 [details] Patch for landing
Adam Barth
Comment 6 2013-01-22 17:36:03 PST
See https://code.google.com/p/chromium/issues/detail?id=137297 I'm going to wait a couple days before landing this patch.
WebKit Review Bot
Comment 7 2013-01-22 18:24:45 PST
Comment on attachment 184086 [details] Patch for landing Attachment 184086 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16037901 New failing tests: fast/notifications/notifications-with-permission.html
Ojan Vafai
Comment 8 2013-01-22 19:22:46 PST
Looks like there's a test you need to update.
Adam Barth
Comment 9 2013-01-22 20:35:29 PST
Yep. I'll take care of it when I land the patch.
Radar WebKit Bug Importer
Comment 10 2013-01-22 22:44:54 PST
<rdar://problem/13067995>
Adam Barth
Comment 11 2013-01-28 11:14:55 PST
Created attachment 185018 [details] Patch for landing
Adam Barth
Comment 12 2013-01-28 11:24:35 PST
Committed r140983: <http://trac.webkit.org/changeset/140983>
WebKit Review Bot
Comment 13 2013-01-29 18:26:38 PST
Re-opened since this is blocked by bug 108277
Ahmad Saleem
Comment 14 2024-02-18 16:51:22 PST
Legacy Notifications gone - https://github.com/WebKit/WebKit/commit/34d6c0d0c6a163321646de3e58e9e2dee5f9d739 Nothing to do here.
Note You need to log in before you can comment on or make changes to this bug.