| Summary: | Fix assertions in make8BitFrom16BitSource() with threaded parser | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Gentilcore <tonyg> | ||||
| Component: | New Bugs | Assignee: | Tony Gentilcore <tonyg> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ojan.autocc, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 106127 | ||||||
| Attachments: |
|
||||||
|
Description
Tony Gentilcore
2013-01-22 15:36:53 PST
Created attachment 184062 [details]
Patch
Comment on attachment 184062 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184062&action=review > Source/WebCore/html/parser/HTMLToken.h:245 > m_externalCharacters = token.data().characters(); > m_externalCharactersLength = token.data().length(); > + m_isAll8BitData = token.isAll8BitData(); This change is fine, but I think we'll need to rethink this "external characters" design as part of this work. Comment on attachment 184062 [details] Patch Clearing flags on attachment: 184062 Committed r140485: <http://trac.webkit.org/changeset/140485> All reviewed patches have been landed. Closing bug. Comment on attachment 184062 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184062&action=review >> Source/WebCore/html/parser/HTMLToken.h:245 >> + m_isAll8BitData = token.isAll8BitData(); > > This change is fine, but I think we'll need to rethink this "external characters" design as part of this work. Agreed. |