Bug 10759

Summary: fast/AppleScript/array.html test failing
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit APIAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: timothy
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://build.webkit.org/results/post-commit-powerpc-mac-os-x/3197/fast/AppleScript/array-diffs.txt
Attachments:
Description Flags
proposed patch darin: review+

Alexey Proskuryakov
Reported 2006-09-06 12:11:39 PDT
I don't understand why, but DRT has started printing a zero array element as " 0e+0" in this test. As stupid as it sounds, it's as if [aeDesc stringValue] has suddenly changed its behavior. I don't have a real explanation. The attached patch works around this by modifying the conversion itself - now integer values are encoded as typeSInt32, rather than typeIEEE64BitFloatingPoint. This has a certain unfortunate "surprise" potential, as the type now depends on the value, but built-in AE type conversion should make this mostly transparent, I hope.
Attachments
proposed patch (2.95 KB, patch)
2006-09-06 12:14 PDT, Alexey Proskuryakov 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2006-09-06 12:14:51 PDT
Created attachment 10422 [details] proposed patch
Darin Adler
Comment 2 2006-09-08 09:57:11 PDT
Comment on attachment 10422 [details] proposed patch r=me
Alexey Proskuryakov
Comment 3 2006-09-09 03:48:23 PDT
Committed revision 16274. (In reply to comment #0) > I don't have a real explanation. I have tried reverting to an older revision, and the behavior was the same. I guess I just made a last-minute change to the DRT output, and didn't re-run the tests (bad!).
Note You need to log in before you can comment on or make changes to this bug.