Bug 107582 – IndexedDB: IDBKeyRange::isOnlyKey() does pointer equality comparison

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Joshua Bell]

To simplify the backend API, various methods that can take a key-or-keyrange just accept a keyrange, and we map a script call with just a key to IDBKeyRange::only(key). On the back end, optimized paths can check keyrange->isOnlyKey()

IDBKeyRange::isOnlyKey() does pointer equality comparison, so if there are IPC hijinks between the front- and back-end (e.g. in multiprocess ports) that don't pass along this flag, the equality comparison would fail and the unoptimized path would be used.

It looks like the only caller is in GetOperation::perform() in IDBDatabaseBackendImpl.cpp

A trivial fix would be to replace the equality test with: !m_lower->compare(m_upper)

[Joshua Bell]

Created attachment 185573 [details]
Patch

[Joshua Bell]

alecflett@ - can you take a look?

[Alec Flett]

nice. lgtm

[Joshua Bell]

tony@ - r?

[WebKit Review Bot]

Comment on attachment 185573 [details]
Patch

Rejecting attachment 185573 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 185573, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 13482 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
53>At revision 13482.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/16183937

[Joshua Bell]

Comment on attachment 185573 [details]
Patch

"Merge conflict during commit: Conflict at '/trunk/Source/WebCore/ChangeLog' at /usr/lib/git-core/git-svn line 570"

Just giving it another try.

[WebKit Review Bot]

Comment on attachment 185573 [details]
Patch

Clearing flags on attachment: 185573

Committed r141338: <http://trac.webkit.org/changeset/141338>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Joshua Bell]

And for the record, this graph shows the associated perf boost pretty well:

http://build.chromium.org/f/chromium/perf/chromium-rel-win7-dual/idb_perf/report.html?history=150&rev=180143&graph=testReadCache_50_true