Bug 107568

Summary: [CSS Exclusions] ExclusionPolygon reflex vertices should constrain the first fit location.
Product: WebKit Reporter: Hans Muller <giles_joplin>
Component: CSSAssignee: Hans Muller <giles_joplin>
Status: RESOLVED FIXED    
Severity: Normal CC: betravis, eric, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 103429    
Bug Blocks: 96813    
Attachments:
Description Flags
Patch none

Description Hans Muller 2013-01-22 10:49:57 PST 
Reflex vertices constrain first fit locations and should contribute offset edges.
Comment 1 Hans Muller 2013-01-22 10:51:24 PST 
*** Bug 107564 has been marked as a duplicate of this bug. ***
Comment 2 Hans Muller 2013-02-13 09:56:03 PST 
Created attachment 188104 [details]
Patch

The ExclusionPolygon::firstIncludedIntervalLogicalTop() method now includes offset edges for each of the polygon's reflex vertices. The motivation for this change is explained here: http://hansmuller-webkit.blogspot.com/2013/01/getting-to-point-reflex-vertices.html.
Comment 3 Dirk Schulze 2013-02-13 14:34:26 PST 
Comment on attachment 188104 [details]
Patch

LGTM. r=me.
Comment 4 WebKit Review Bot 2013-02-13 14:45:17 PST 
Comment on attachment 188104 [details]
Patch

Clearing flags on attachment: 188104

Committed r142805: <http://trac.webkit.org/changeset/142805>
Comment 5 WebKit Review Bot 2013-02-13 14:45:20 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Hans Muller 2013-02-13 16:35:37 PST 
*** Bug 108107 has been marked as a duplicate of this bug. ***