Bug 10752 – The inspector should not respond to Make Text Smaller/Bigger commands

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

When the Inspector is focused, Safari's View > Make Text Smaller/Bigger commands target it, and the results aren't pretty.

[Rob Buis]

Created attachment 14627 [details]
First  attempt

This fixes the problem in the inspector, unfortunately no way to autotest I think.
Cheers,

Rob.

Comment on attachment 14627 [details]
First  attempt

Is it possible to make a layout test for this part?

-            if (type != CSSPrimitiveValue::CSS_EMS && type != CSSPrimitiveValue::CSS_EXS && view && view->frame()) {
+            if (type != CSSPrimitiveValue::CSS_EMS && type != CSSPrimitiveValue::CSS_EXS && style->textSizeAdjust() && view && view->frame()) {

[Maciej Stachowiak]

Comment on attachment 14627 [details]
First  attempt

I think Mitz is right that the change for handling of -webkit-text-size-adjust can be tested, even if not in the inspector. Please add a test case.

[Timothy Hatcher]

Ideally the inspector should work with text zoom.

[Rob Buis]

Created attachment 15398 [details]
Now with testcase

This time there is a testcase, since I can now also zoom in/out, bug 14209 patch is also in this patch.
Cheers,

Rob.

[Rob Buis]

Created attachment 15405 [details]
Slight tweaks

The testcase contained some garbage and was in the wrong dir, this patch fixes that.
Cheers,

Rob.

Comment on attachment 15405 [details]
Slight tweaks

r=me

[Rob Buis]

Landed in r24097.

[Matt Lilek]

See bug 14588 for followup