Bug 107400 – [GTK] Debug build failure on x86-64

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Michael Pruett]

The debug build of libWebCore.a on x86_64 has once again exceeded 4GB, and debug builds fail with the following message:

  CXXLD  Programs/WebKitPluginProcess
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 758134
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 3488834
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 6576910
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 9418130
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 12996814
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 15659050
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 18302758
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 24501258
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 27468022
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 34344190
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 40140894
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 49532658
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 53213622
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 56496818
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 59161726
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 62448082
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 65736998
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 68839386
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 77786086
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 81150146
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 84262310
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 86338682
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 86551442
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 86649582
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 86774634
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 86898174
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 87021058
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 89037382
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 91912538
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 92154670
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 21049470
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 30625130
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 37076994
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 72116982
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 75119226
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 86478718
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 94966482
/usr/bin/ld: error: ./.libs/libWebCore.a: malformed archive header at 95505998
collect2: error: ld returned 1 exit status
make[1]: *** [Programs/WebKitPluginProcess] Error 1
make[1]: Leaving directory `/home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug'
make: *** [all] Error 2

[Michael Pruett]

The same problem has surfaced in the recent past in bug 102347.

[Gustavo Noronha (kov)]

*** Bug 107401 has been marked as a duplicate of this bug. ***

[Michael Pruett]

Created attachment 183682 [details]
Patch

[Michael Pruett]

Created attachment 183684 [details]
Patch

I've updated the ChangeLog entries with a better explanation of this change.

[Gustavo Noronha (kov)]

Comment on attachment 183684 [details]
Patch

As we discussed on IRC this unfortunately won't work since the plugin process is not working for whatever reason. We'll have to think of something else.

[Gustavo Noronha (kov)]

Created attachment 184008 [details]
Patch

[Gustavo Noronha (kov)]

How about this? It fixes the problem and gains us faster, less diskspace-demanding builds. I remember we had trouble setting AR_FLAGS globally for the bots because some modules did not build correctly in jhbuild, but this should not cause that problem since it'll be limited to the actual WebKitGTK+ build.

[Gustavo Noronha (kov)]

Created attachment 184012 [details]
Patch

[Gustavo Noronha (kov)]

From IRC:

<mrobinson> kov: Maybe in build-webkit?

One reason why I think this should be in the build system is it'll also affect downstream builds. Most distributions build with debugging symbols enabled, so it's quite likely they'd hit this problem and have to solve it themselves.

<mrobinson> You probably don't want to override them if someone has already set it in the environment.

This has been done in the new patch.

<mrobinson> I think thin archive support varies from system to system.
<kov> do we know of one that doesn't have it?
<mrobinson> kov: At some point it was turned on for Chromium and then turned off again because of compatibility issues.
<mrobinson> Evan Martin might have the details.

I would prefer to adopt this solution unless we know of a system that's worth supporting and doesn't have support for thin archives. Maybe we should try enabling it and see if we find that system? I'll try asking Evan.

[Xan Lopez]

Comment on attachment 184012 [details]
Patch

I think it makes sense to do this now and see what happens. If someone complains we could also try to only do it on GNU/Linux. So r+ here, let's commit if nobody objects strongly.

[Gustavo Noronha (kov)]

Committed r140440: <http://trac.webkit.org/changeset/140440>

[Tobias Mueller]

Hm. I might be running into an issue caused by the thin archive created indicated in bug 108330.
The Internet also knows about this: http://queues.webkit.org/results/12434168 http://queues.webkit.org/results/12656389

[Gustavo Noronha (kov)]

The problems you linked to were fixed by doing a clean build, that should fix it for you as well, hopefully =)