Summary: | Inserting a node into the DFG graph should not require five lines of code | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam, webkit-ews, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 106868 | ||||||||||
Attachments: |
|
Description
Filip Pizlo
2013-01-19 14:36:38 PST
Created attachment 183634 [details]
work in progress
Created attachment 183648 [details]
the patch
Attachment 183648 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/dfg/DFGVariadicFunction.h:46: Extra space before ) [whitespace/parens] [2]
Source/JavaScriptCore/dfg/DFGBasicBlock.h:105: The parameter name "graph" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGBasicBlock.h:105: The parameter name "refChildrenMode" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGBasicBlock.h:105: The parameter name "refNodeMode" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGBasicBlock.h:105: The parameter name "valueParams" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:549: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 6 in 16 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 183648 [details] the patch Attachment 183648 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15978380 Comment on attachment 183648 [details] the patch Attachment 183648 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15967396 Created attachment 183650 [details]
the patch
Attachment 183650 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/dfg/DFGVariadicFunction.h:46: Extra space before ) [whitespace/parens] [2]
Source/JavaScriptCore/dfg/DFGBasicBlock.h:105: The parameter name "valueParams" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 2 in 16 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Landed in http://trac.webkit.org/changeset/140275 |