Bug 107381

Summary:

Inserting a node into the DFG graph should not require five lines of code

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam, webkit-ews, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

106868

Attachments:

Description	Flags
work in progress	none
the patch	eflews.bot: commit-queue-
the patch	sam: review+

Filip Pizlo

Reported 2013-01-19 14:36:38 PST

Patch forthcoming

Attachments
work in progress (46.60 KB, patch) 2013-01-19 14:38 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (58.92 KB, patch) 2013-01-19 18:21 PST, Filip Pizlo	eflews.bot: commit-queue-	Details Formatted Diff Diff
the patch (58.94 KB, patch) 2013-01-19 18:36 PST, Filip Pizlo	sam: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2013-01-19 14:38:01 PST

Created attachment 183634 [details] work in progress

Filip Pizlo

Comment 2 2013-01-19 18:21:14 PST

Created attachment 183648 [details] the patch

WebKit Review Bot

Comment 3 2013-01-19 18:27:05 PST

Attachment 183648 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGVariadicFunction.h:46: Extra space before ) [whitespace/parens] [2] Source/JavaScriptCore/dfg/DFGBasicBlock.h:105: The parameter name "graph" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/dfg/DFGBasicBlock.h:105: The parameter name "refChildrenMode" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/dfg/DFGBasicBlock.h:105: The parameter name "refNodeMode" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/dfg/DFGBasicBlock.h:105: The parameter name "valueParams" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:549: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 6 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 4 2013-01-19 18:30:20 PST

Comment on attachment 183648 [details] the patch Attachment 183648 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15978380

Early Warning System Bot

Comment 5 2013-01-19 18:33:58 PST

Comment on attachment 183648 [details] the patch Attachment 183648 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15967396

Filip Pizlo

Comment 6 2013-01-19 18:36:02 PST

Created attachment 183650 [details] the patch

WebKit Review Bot

Comment 7 2013-01-19 18:42:52 PST

Attachment 183650 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGVariadicFunction.h:46: Extra space before ) [whitespace/parens] [2] Source/JavaScriptCore/dfg/DFGBasicBlock.h:105: The parameter name "valueParams" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 8 2013-01-20 11:31:45 PST

Landed in http://trac.webkit.org/changeset/140275

Note You need to log in before you can comment on or make changes to this bug.