Bug 10738

Summary:

Consolidate the Objective-C DOM Bindings Internal files into DOMInternal.h

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
patch	timothy: review+

Sam Weinig

Reported 2006-09-05 09:08:56 PDT

Get rid of DOMHTMLInternal.h, DOMCSSInternal.h, DOMEventsInternal.h, DOMViewsInternal.h and DOMXPathInternal.h to make auto-generation easier. Eventually, we will want to auto-generate DOMInternal,h as well.

Attachments
patch (74.89 KB, patch) 2006-09-05 09:31 PDT, Sam Weinig	timothy: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2006-09-05 09:31:06 PDT

Created attachment 10401 [details] patch - Consolidate DOMHTMLInternal.h, DOMCSSInternal.h, DOMEventsInternal.h, DOMViewsInternal.h and DOMXPathInternal.h into DOMInternal.h. - Rename the "type-makers" (used to make a binding from an implementation type) so that all the HTML ones begin with the prefix HTML. Did the same for the CSS. - Auto-generate a couple more methods from DOMExtensions.h. - Various cleanups of the Objective-C auto-generation code.

Timothy Hatcher

Comment 2 2006-09-05 09:47:46 PDT

Comment on attachment 10401 [details] patch r=me, nice cleanup!

Sam Weinig

Comment 3 2006-09-05 10:01:26 PDT

Landed in r16229.

Note You need to log in before you can comment on or make changes to this bug.