Bug 107368

Summary: Add a helper function for getting strings from tokens (and make it 8-bit aware)
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED WORKSFORME    
Severity: Normal CC: abarth, benjamin, ojan.autocc, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 106127    
Attachments:
Description Flags
Patch abarth: review-

Eric Seidel (no email)
Reported 2013-01-19 02:56:36 PST
Add a helper function for getting strings from tokens (and make it 8-bit aware)
Attachments
Patch (3.52 KB, patch)
2013-01-19 02:58 PST, Eric Seidel (no email) 		abarth: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2013-01-19 02:58:01 PST
Created attachment 183614 [details] Patch
Adam Barth
Comment 2 2013-01-19 11:10:14 PST
Comment on attachment 183614 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183614&action=review > Source/WebCore/html/parser/CompactHTMLToken.cpp:40 > + if (!vector.size()) > + return emptyString(); There's no reason to do this. Both String::make8BitFrom16BitSource and String have special-case logic for the empty string. > Source/WebCore/html/parser/CompactHTMLToken.cpp:41 > + if (token.isAll8BitData()) This isn't correct for anything other than m_data. We only track this flag for the main data vector. Perhaps we should make HTMLToken smarter and track this flag for the other strings as well?
Adam Barth
Comment 3 2013-02-13 21:35:01 PST
Eric did this in a more general way.
Note You need to log in before you can comment on or make changes to this bug.