Summary: | HTMLOptionElement should not allow setting the text and index attributes | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
Component: | DOM | Assignee: | Alexey Proskuryakov <ap> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap | ||||
Priority: | P2 | ||||||
Version: | 420+ | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
Sam Weinig
2006-09-04 15:39:13 PDT
Created attachment 16913 [details]
proposed patch
HTMLOptionElement.index is read-only in IE and DOM (both DOM 2 and DOM 1 Second Edition), so if I'm not missing something, Firefox is wrong to raise an exception.
HTMLOptionElement.text is settable in both IE and Firefox, so I don't think that we should change this.
Comment on attachment 16913 [details]
proposed patch
Why not add a newline at the end of the test file?
Shouldn't you also remove HTMLOptionElement::setIndex from HTMLOptionElement.cpp/h?
Otherwise, r=me
(In reply to comment #2) > Why not add a newline at the end of the test file? Done. > Shouldn't you also remove HTMLOptionElement::setIndex from > HTMLOptionElement.cpp/h? Done. > Otherwise, r=me Committed revision 27217. |