Bug 107324

Summary: Asserts when textPath is used with no path
Product: WebKit Reporter: Stephen Chenney <schenney>
Component: SVGAssignee: Stephen Chenney <schenney>
Status: RESOLVED FIXED    
Severity: Normal CC: d-r, eric, fmalita, krit, ojan.autocc, pdr, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric: review+

Stephen Chenney
Reported 2013-01-18 13:58:30 PST
We assert in SVGTextLayoutEngine when the textPath element has no path associated with it: ASSERTION FAILED: ok ../../third_party/WebKit/Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp(562) : void WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath(WebCore::SVGInlineTextBox *, WebCore::RenderSVGInlineText *, const WebCore::RenderStyle *) Turns out that we totally fail to check for this case, which normally isn't a problem (this is not a security issue) because the text path just returns 0,0 or something for any point on the path when the path doesn't exist. Fix imminent.
Attachments
Patch (3.58 KB, patch)
2013-01-18 14:42 PST, Stephen Chenney 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephen Chenney
Comment 1 2013-01-18 14:42:00 PST
Created attachment 183550 [details] Patch
Eric Seidel (no email)
Comment 2 2013-01-18 14:48:36 PST
Comment on attachment 183550 [details] Patch So long as this early return leaves the rendering tree in an expected state, then this seems fine.
Stephen Chenney
Comment 3 2013-01-22 08:54:21 PST
Committed r140429: <http://trac.webkit.org/changeset/140429>
Note You need to log in before you can comment on or make changes to this bug.