Allow construction of unprefixed transition DOM events.

• Component: DOM
• Status: RESOLVED FIXED

[Alexis Menard (darktears)]

Allow construction of unprefixed transition DOM events.

[Alexis Menard (darktears)]

Created attachment 183535 [details]
Patch

[WebKit Review Bot]

Comment on attachment 183535 [details]
Patch

Attachment 183535 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15941812

[Build Bot]

Comment on attachment 183535 [details]
Patch

Attachment 183535 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/15946592

New failing tests:
fast/dom/constructed-objects-prototypes.html

[Peter Beverloo (cr-android ews)]

Comment on attachment 183535 [details]
Patch

Attachment 183535 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15939813

[Build Bot]

Comment on attachment 183535 [details]
Patch

Attachment 183535 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15945750

New failing tests:
fast/dom/constructed-objects-prototypes.html

[Build Bot]

Comment on attachment 183535 [details]
Patch

Attachment 183535 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15942776

New failing tests:
fast/dom/constructed-objects-prototypes.html

[Alexis Menard (darktears)]

Created attachment 183752 [details]
Patch

[WebKit Review Bot]

Comment on attachment 183752 [details]
Patch

Attachment 183752 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15970989

[Alexis Menard (darktears)]

Created attachment 183761 [details]
Patch

[WebKit Review Bot]

Comment on attachment 183761 [details]
Patch

Attachment 183761 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16038032

New failing tests:
fast/events/event-creation.html

[WebKit Review Bot]

Comment on attachment 183761 [details]
Patch

Attachment 183761 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16011333

New failing tests:
fast/events/event-creation.html
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

[Alexis Menard (darktears)]

Created attachment 183822 [details]
Patch

[Dean Jackson]

Comment on attachment 183822 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183822&action=review

> Source/WebCore/ChangeLog:20
> +        Make possible to construct unprefixed DOM events for transitions.
> +        Unfortunately I have to duplicate the C++ implementation class of the
> +        events (TransitionEvent.h and TransitionEvent.cpp). I can't find a
> +        better way to re-use the WebKitTransitionEvent class to back the
> +        TransitionEvent.idl as our code generators don't allow to have a
> +        different name for the C++ class used in the generated file than the
> +        interface name specified in the IDL file. Unfortunately
> +        https://trac.webkit.org/wiki/WebKitIDL#InterfaceName doesn't help as
> +        it's only a way to unlink the interface name specified in the IDL with
> +        the one exposed in JavaScript. I don't think we should support such a
> +        feature in our code generators as WebKitTransitionEvent class and more
> +        exactly prefixed DOM events for transitions will be removed one day so
> +        this use case will become obselete.

I wonder if we should put a big message in the unprefixed implementation making it clear that any change should be done in both places (as unlikely as this is).

[WebKit Review Bot]

Comment on attachment 183822 [details]
Patch

Clearing flags on attachment: 183822

Committed r140448: <http://trac.webkit.org/changeset/140448>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Alexis Menard (darktears)]

(In reply to comment #13)
> (From update of attachment 183822 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=183822&action=review
> 
> > Source/WebCore/ChangeLog:20
> > +        Make possible to construct unprefixed DOM events for transitions.
> > +        Unfortunately I have to duplicate the C++ implementation class of the
> > +        events (TransitionEvent.h and TransitionEvent.cpp). I can't find a
> > +        better way to re-use the WebKitTransitionEvent class to back the
> > +        TransitionEvent.idl as our code generators don't allow to have a
> > +        different name for the C++ class used in the generated file than the
> > +        interface name specified in the IDL file. Unfortunately
> > +        https://trac.webkit.org/wiki/WebKitIDL#InterfaceName doesn't help as
> > +        it's only a way to unlink the interface name specified in the IDL with
> > +        the one exposed in JavaScript. I don't think we should support such a
> > +        feature in our code generators as WebKitTransitionEvent class and more
> > +        exactly prefixed DOM events for transitions will be removed one day so
> > +        this use case will become obselete.
> 
> I wonder if we should put a big message in the unprefixed implementation making it clear that any change should be done in both places (as unlikely as this is).

We still have the "pseudoElementArg of type DOMString" part of the event attributes which we do not implement. Ok it has an issue coming with it so I'm not sure if we will implement it one day.

[Lucas Forschler]

Mass move bugs into the DOM component.