Bug 107270 – [chromium] move methods interacting with willSendRequest to TestRunner

• Component: Tools / Tests
• Status: RESOLVED FIXED

// Causes WillSendRequest to clear certain headers.
    void setWillSendRequestClearHeader(const CppArgumentList&, CppVariant*);

    // Causes WillSendRequest to block redirects.
    void setWillSendRequestReturnsNullOnRedirect(const CppArgumentList&, CppVariant*);

    // Causes WillSendRequest to return an empty request.
    void setWillSendRequestReturnsNull(const CppArgumentList&, CppVariant*);

Created attachment 183686 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Comment on attachment 183686 [details]
Patch

Attachment 183686 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16011040

New failing tests:
media/media-blocked-by-willsendrequest.html
http/tests/misc/will-send-request-returns-null-on-redirect.html

Created attachment 183743 [details]
Patch

[Kent Tamura]

Comment on attachment 183743 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183743&action=review

> Tools/DumpRenderTree/chromium/WebViewHost.cpp:898
> +    if (request.url().isEmpty())
> +        return;

Why is this needed?

Comment on attachment 183743 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183743&action=review

>> Tools/DumpRenderTree/chromium/WebViewHost.cpp:898
>> +        return;
> 
> Why is this needed?

WebTestProxyBase::willSendRequest can replace the request with an empty request to block the request.

Without this, the call to webkit_support::RewriteLayoutTestsURL at the end of willSendRequest will put there a non-empty URL, and the request doesn't get blocked

[Kent Tamura]

Comment on attachment 183743 [details]
Patch

looks ok

[WebKit Review Bot]

Comment on attachment 183743 [details]
Patch

Clearing flags on attachment: 183743

Committed r140318: <http://trac.webkit.org/changeset/140318>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.