| Summary: | [chromium] move methods interacting with willSendRequest to TestRunner | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | jochen | ||||||
| Component: | Tools / Tests | Assignee: | jochen | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, dcarney, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 91308 | ||||||||
| Attachments: |
|
||||||||
Created attachment 183686 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 183686 [details] Patch Attachment 183686 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16011040 New failing tests: media/media-blocked-by-willsendrequest.html http/tests/misc/will-send-request-returns-null-on-redirect.html Created attachment 183743 [details]
Patch
Comment on attachment 183743 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183743&action=review > Tools/DumpRenderTree/chromium/WebViewHost.cpp:898 > + if (request.url().isEmpty()) > + return; Why is this needed? Comment on attachment 183743 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183743&action=review >> Tools/DumpRenderTree/chromium/WebViewHost.cpp:898 >> + return; > > Why is this needed? WebTestProxyBase::willSendRequest can replace the request with an empty request to block the request. Without this, the call to webkit_support::RewriteLayoutTestsURL at the end of willSendRequest will put there a non-empty URL, and the request doesn't get blocked Comment on attachment 183743 [details]
Patch
looks ok
Comment on attachment 183743 [details] Patch Clearing flags on attachment: 183743 Committed r140318: <http://trac.webkit.org/changeset/140318> All reviewed patches have been landed. Closing bug. |
// Causes WillSendRequest to clear certain headers. void setWillSendRequestClearHeader(const CppArgumentList&, CppVariant*); // Causes WillSendRequest to block redirects. void setWillSendRequestReturnsNullOnRedirect(const CppArgumentList&, CppVariant*); // Causes WillSendRequest to return an empty request. void setWillSendRequestReturnsNull(const CppArgumentList&, CppVariant*);