Bug 107269

Summary:

[chromium] move notification related methods to TestRunner

Product:

WebKit

Reporter:

jochen

Component:

Tools / Tests

Assignee:

jochen

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dcarney, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

91308

Attachments:

Description	Flags
Patch	none
Patch for landing	none

jochen

Reported 2013-01-18 05:44:52 PST

// Grants permission for desktop notifications to an origin void grantWebNotificationPermission(const CppArgumentList&, CppVariant*); // Simulates a click on a desktop notification. void simulateLegacyWebNotificationClick(const CppArgumentList&, CppVariant*);

Attachments
Patch (10.93 KB, patch) 2013-01-19 12:52 PST, jochen	no flags	Details Formatted Diff Diff
Patch for landing (11.12 KB, patch) 2013-01-20 01:49 PST, jochen	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

jochen

Comment 1 2013-01-19 12:52:13 PST

Created attachment 183631 [details] Patch

WebKit Review Bot

Comment 2 2013-01-19 12:55:41 PST

Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

jochen

Comment 3 2013-01-20 01:49:16 PST

Created attachment 183661 [details] Patch for landing

WebKit Review Bot

Comment 4 2013-01-20 02:51:33 PST

Comment on attachment 183661 [details] Patch for landing Clearing flags on attachment: 183661 Committed r140271: <http://trac.webkit.org/changeset/140271>

WebKit Review Bot

Comment 5 2013-01-20 02:51:37 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.