Bug 107235

Summary: REGRESSION(r140005): broke downstream Chromium interactive_ui_tests (Requested by dominicc on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: dominicc, japhet, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 105667    
Attachments:
Description Flags
ROLLOUT of r140005 none

Description WebKit Review Bot 2013-01-18 00:11:15 PST
http://trac.webkit.org/changeset/140005 broke the build:
broke downstream Chromium interactive_ui_tests (Requested by dominicc on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2013-01-18 00:11:48 PST
Created attachment 183390 [details]
ROLLOUT of r140005

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Dominic Cooney 2013-01-18 00:14:02 PST
Specifically these ones:

BackspaceSentToWebContent
EscapeCloseConstrainedWindow

broke when WebKit rolled in Chromium revision 177618:

<http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29&number=19453>
<http://build.chromium.org/p/chromium.win/buildstatus?builder=Interactive%20Tests%20%28dbg%29&number=32707>
Comment 3 Dominic Cooney 2013-01-18 00:28:01 PST
Comment on attachment 183390 [details]
ROLLOUT of r140005

Clearing flags on attachment: 183390

Committed r140105: <http://trac.webkit.org/changeset/140105>
Comment 4 Dominic Cooney 2013-01-18 00:28:05 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Dominic Cooney 2013-01-18 02:07:07 PST
For the fossil record, this was filed as <https://code.google.com/p/chromium/issues/detail?id=170853> downstream.

Chromium rolled to the rollout of this change at revision (ie downstream) 177624 and it seems r140005 was responsible for the test breaks noted above.

It probably also caused these Android failures:

<http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/6518/steps/androidwebview_instrumentation_tests/logs/stdio>

CRITICAL:root:org.chromium.android_webview.test.AwSettingsTest#testContentUrlFromFileWithTwoViews
CRITICAL:root:junit.framework.AssertionFailedError: expected:<1> but was:<0>
	at org.chromium.android_webview.test.AwSettingsTest.ensureResourceRequestCountInContentProvider(AwSettingsTest.java:2239)
	at org.chromium.android_webview.test.AwSettingsTest.access$200(AwSettingsTest.java:42)
	at org.chromium.android_webview.test.AwSettingsTest$AwSettingsContentUrlAccessFromFileTestHelper.doEnsureSettingHasValue(AwSettingsTest.java:790)
	at org.chromium.android_webview.test.AwSettingsTest$AwSettingsContentUrlAccessFromFileTestHelper.doEnsureSettingHasValue(AwSettingsTest.java:742)
	at org.chromium.android_webview.test.AwSettingsTest$AwSettingsTestHelper.ensureSettingHasValue(AwSettingsTest.java:127)
	at org.chromium.android_webview.test.AwSettingsTest$AwSettingsTestHelper.ensureSettingHasInitialValue(AwSettingsTest.java:76)
	at org.chromium.android_webview.test.AwSettingsTest.runPerViewSettingsTest(AwSettingsTest.java:2186)
	at org.chromium.android_webview.test.AwSettingsTest.testContentUrlFromFileWithTwoViews(AwSettingsTest.java:1565)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:169)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:154)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:545)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1551)
CRITICAL:root:org.chromium.android_webview.test.AwSettingsTest#testContentUrlAccessWithTwoViews
CRITICAL:root:junit.framework.AssertionFailedError: expected:<1> but was:<0>
	at org.chromium.android_webview.test.AwSettingsTest.ensureResourceRequestCountInContentProvider(AwSettingsTest.java:2239)
	at org.chromium.android_webview.test.AwSettingsTest.access$200(AwSettingsTest.java:42)
	at org.chromium.android_webview.test.AwSettingsTest$AwSettingsContentUrlAccessTestHelper.doEnsureSettingHasValue(AwSettingsTest.java:733)
	at org.chromium.android_webview.test.AwSettingsTest$AwSettingsContentUrlAccessTestHelper.doEnsureSettingHasValue(AwSettingsTest.java:698)
	at org.chromium.android_webview.test.AwSettingsTest$AwSettingsTestHelper.ensureSettingHasValue(AwSettingsTest.java:127)
	at org.chromium.android_webview.test.AwSettingsTest$AwSettingsTestHelper.ensureSettingHasInitialValue(AwSettingsTest.java:76)
	at org.chromium.android_webview.test.AwSettingsTest.runPerViewSettingsTest(AwSettingsTest.java:2189)
	at org.chromium.android_webview.test.AwSettingsTest.testContentUrlAccessWithTwoViews(AwSettingsTest.java:1534)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:169)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:154)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:545)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1551)