Bug 107205

Summary: REGRESSION(r137726): Spring Loaded Pan Scrolling doesn't stop
Product: WebKit Reporter: yosin
Component: UI EventsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch 1
none
Patch 2 none

Description yosin 2013-01-17 17:32:31 PST
Import from http://crbug.com/167238

= Re-produce steps =
1. Open scrollable page.
2. Hold middle mouse button and move pointer around to start scrolling
3. Release middle mouse button

= Result =
Continue scrolling

= Expectation =
Stop scrolling when releaseing mouse.
Comment 1 yosin 2013-01-17 21:07:26 PST
Created attachment 183364 [details]
Patch 1
Comment 2 yosin 2013-01-17 21:08:23 PST
Comment on attachment 183364 [details]
Patch 1

Could you review this patch?
Thanks in advance.
Comment 3 WebKit Review Bot 2013-01-17 22:53:42 PST
Comment on attachment 183364 [details]
Patch 1

Attachment 183364 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15937553

New failing tests:
platform/chromium-win/fast/events/panScroll-drag.html
platform/chromium-win/fast/events/panScroll-click.html
Comment 4 Hajime Morrita 2013-01-17 22:56:59 PST
Comment on attachment 183364 [details]
Patch 1

An approach looks good. It's great to get rid of extra flags.

About state name.
MouseDown/MouseUp is unclear here AutoScrollController doesn't handle mouse event directly for pan scroll.
It looks we have existing AutoscrollForPan and an extra state which indicates AutoscrollForPan is finishing. 
Can we just add an enum for that instead of replace AutoScroll into two state?

Also, we need TestExpectations for non-windows platforms.
Comment 5 yosin 2013-01-17 23:17:55 PST
Created attachment 183385 [details]
Patch 2
Comment 6 yosin 2013-01-17 23:19:50 PST
Comment on attachment 183385 [details]
Patch 2

Could you review this patch?
Thanks in advance.

= Changes since the last review =
* Update platform/chromium/TestExpecation for skipping newly added pan scroll tests.
* Use AutoscrollForPanCanStop instead of AutoscrollForPan{Before,After}MouseUp.
Comment 7 WebKit Review Bot 2013-01-18 00:24:02 PST
Comment on attachment 183385 [details]
Patch 2

Clearing flags on attachment: 183385

Committed r140104: <http://trac.webkit.org/changeset/140104>
Comment 8 WebKit Review Bot 2013-01-18 00:24:06 PST
All reviewed patches have been landed.  Closing bug.