Summary: | IndexedDB: Conditionalize usage of env_idb.h to fix build for non-Chromium ports | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Pruett <michael> | ||||||
Component: | New Bugs | Assignee: | Martin Robinson <mrobinson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dgrogan, jsbell, mrobinson, tony | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Michael Pruett
2013-01-17 14:48:55 PST
Created attachment 183301 [details]
Patch
Comment on attachment 183301 [details]
Patch
lgtm
Thanks David. I'll wait for all the bubbles to turn green before committing this. Comment on attachment 183301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183301&action=review > Source/WebCore/platform/leveldb/LevelDBDatabase.cpp:58 > +#if PLATFORM(CHROMIUM) > +static leveldb::Env* defaultLevelDBEnvironment() > +{ > + return leveldb::IDBEnv(); > +} > +#else > +static leveldb::Env* defaultLevelDBEnvironment() Nit: Why not scope the #if around the return? (In reply to comment #4) > (From update of attachment 183301 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=183301&action=review > > > Source/WebCore/platform/leveldb/LevelDBDatabase.cpp:58 > > +#if PLATFORM(CHROMIUM) > > +static leveldb::Env* defaultLevelDBEnvironment() > > +{ > > + return leveldb::IDBEnv(); > > +} > > +#else > > +static leveldb::Env* defaultLevelDBEnvironment() > > Nit: Why not scope the #if around the return? Just my preference against having conditional compilation inside functions instead of surrounding them. Michael actually suggested a way to make this patch simpler, so I'll try that. Created attachment 183318 [details]
Patch
Committed r140099: <http://trac.webkit.org/changeset/140099> |