| Summary: | Make Console::shouldPrintExceptions work in WebKit2 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||
| Component: | WebKit2 | Assignee: | Timothy Hatcher <timothy> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, joepeck | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Timothy Hatcher
2013-01-17 12:19:59 PST
Created attachment 183244 [details]
Proposed Change
Comment on attachment 183244 [details] Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=183244&action=review r=me with the switch to Settings.in > Source/WebCore/page/Console.cpp:218 > + for (unsigned i = 0; i < arguments->argumentCount(); ++i) { NiT: You might as well update `i` to size_t here. ScriptArguments::argumentCount returns a size_t. > Source/WebCore/page/Console.cpp:227 > for (unsigned i = 0; i < callStack->size(); ++i) { Ditto for ScriptCallstack::size. > Source/WebCore/page/Settings.h:372 > + bool m_logsPageMessagesToSystemConsoleEnabled : 1; For simple boolean settings like this you should use probably declare it in "Source/WebCore/page/Settings.in". A single line: logsPageMessagesToSystemConsoleEnabled initial=false That would also take care of initialization this in the constructor, which appears to be missing from this patch. And getters should be const. |