Bug 107157

Summary: Make Console::shouldPrintExceptions work in WebKit2
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: WebKit2Assignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, joepeck
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed Change joepeck: review+, joepeck: commit-queue-

Timothy Hatcher
Reported 2013-01-17 12:19:59 PST
Logging console messages to stdout helps working on the Web Inspector.
Attachments
Proposed Change (15.95 KB, patch)
2013-01-17 12:26 PST, Timothy Hatcher 		joepeck: review+
joepeck: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2013-01-17 12:26:56 PST
Created attachment 183244 [details] Proposed Change
Joseph Pecoraro
Comment 2 2013-01-17 12:46:15 PST
Comment on attachment 183244 [details] Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=183244&action=review r=me with the switch to Settings.in > Source/WebCore/page/Console.cpp:218 > + for (unsigned i = 0; i < arguments->argumentCount(); ++i) { NiT: You might as well update `i` to size_t here. ScriptArguments::argumentCount returns a size_t. > Source/WebCore/page/Console.cpp:227 > for (unsigned i = 0; i < callStack->size(); ++i) { Ditto for ScriptCallstack::size. > Source/WebCore/page/Settings.h:372 > + bool m_logsPageMessagesToSystemConsoleEnabled : 1; For simple boolean settings like this you should use probably declare it in "Source/WebCore/page/Settings.in". A single line: logsPageMessagesToSystemConsoleEnabled initial=false That would also take care of initialization this in the constructor, which appears to be missing from this patch. And getters should be const.
Timothy Hatcher
Comment 3 2013-01-17 14:34:22 PST
r140044
Benjamin Poulain
Comment 4 2013-01-17 15:28:03 PST
+ http://trac.webkit.org/changeset/140060
Note You need to log in before you can comment on or make changes to this bug.