| Summary: | [WK2] svg/dom/fuzz-path-parser.html is failing | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||
| Component: | Tools / Tests | Assignee: | Zan Dobersek <zan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, buildbot, ossy, rniwa, sam, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Zan Dobersek
2013-01-17 08:59:02 PST
Created attachment 183198 [details]
Patch
Comment on attachment 183198 [details] Patch Attachment 183198 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/15938181 New failing tests: http/tests/security/contentSecurityPolicy/source-list-parsing-nonascii.html fast/frames/sandboxed-iframe-attribute-parsing-03.html http/tests/websocket/tests/hybi/long-invalid-header.html Comment on attachment 183198 [details]
Patch
EWS disagrees, the patch is wrong.
Created attachment 183519 [details]
Patch
Comment on attachment 183519 [details]
Patch
Seems to make sense. Did you check why this is not an issue in DumpRenderTree?
(In reply to comment #5) > (From update of attachment 183519 [details]) > Seems to make sense. Did you check why this is not an issue in DumpRenderTree? Implementations in DRT print out the console message through printf. String arguments to that method are printed only up to the first null character, so printf("a: %s\n", "b\0c") would print out "a: b\n". Comment on attachment 183519 [details] Patch Clearing flags on attachment: 183519 Committed r140258: <http://trac.webkit.org/changeset/140258> All reviewed patches have been landed. Closing bug. It broke the build on Qt-WK2 because of the following warning: /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: In member function ‘void WTR::InjectedBundlePage::willAddMessageToConsole(WKStringRef, uint32_t)’: /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:1434:29: error: comparison is always true due to limited range of data type [-Werror=type-limits] cc1plus: all warnings being treated as errors (In reply to comment #9) > It broke the build on Qt-WK2 because of the following warning: > ... Sorry for the breakage, fixed in r140268. http://trac.webkit.org/changeset/140268 |