| Summary: | [BlackBerry] Race condition clearing invalid proxy credentials in NetworkJob | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joe Mason <joenotcharles> | ||||||
| Component: | Page Loading | Assignee: | Joe Mason <joenotcharles> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | mifenton, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | Other | ||||||||
| Attachments: |
|
||||||||
Created attachment 183182 [details]
fix
Comment on attachment 183182 [details] fix Rejecting attachment 183182 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 13388 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 53>At revision 13388. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/15943093 Created attachment 183476 [details]
rebased patch
Rebased
Comment on attachment 183476 [details] rebased patch Clearing flags on attachment: 183476 Committed r140164: <http://trac.webkit.org/changeset/140164> All reviewed patches have been landed. Closing bug. |
NetworkJob contains this code when sending a request with proxy auth credentials: // Prevent them from been used again if they are wrong. // If they are correct, they will be put into CredentialStorage. if (!proxyInfo.address.empty()) { proxyInfo.username.clear(); proxyInfo.password.clear(); BlackBerry::Platform::Settings::instance()->storeProxyCredentials(proxyInfo); } Later when notifyAuthReceived is called, the credentials used are saved in CredentialStorage if "success" is true, or purged if "success" is false. The intent is that from this point forward the credentials will be read from CredentialStorage rather than Platform::Settings, and if the credentials did not succeed they will not be in CredentialStorage so the browser will re-prompt. Two problems with this: 1. If the proxy server is slow to respond, another request could go out before the success result is received, and since the credentials have already been cleared this request would prompt the user for credentials even though the saved credentials are correct. 2. In CredentialStorage, the credentials are indexed by auth type, and in Settings they are not. So after successfully authenticating with, for instance, NTLM auth, the credentials will be stored with NTLM but cleared from Settings. If the proxy server is then reconfigured to ask for Digest auth, the browser will prompt for credentials again rather than using the saved credentials.